Skip to content

Comments

Fix/settings title change#1081

Merged
ThinuwanW merged 2 commits intodevelopfrom
fix/settings-title-change
Feb 20, 2026
Merged

Fix/settings title change#1081
ThinuwanW merged 2 commits intodevelopfrom
fix/settings-title-change

Conversation

@shakila-kamalasena
Copy link
Contributor

PR checklist

TaskId: (https://github.com/SkappHQ/skapp/issues/[id])

Summary

How to test

Project Checklist

  • Changes build without any errors
  • Have written adequate test cases
  • Done developer testing in
    • Chrome
    • Firefox
    • Safari
  • Code is formatted with npm run format
  • Code is linted with npm run check-lint
  • No unnecessary comments left in code
  • Made corresponding changes to the documentation

Other

  • New atomic components added
  • New molecules added
  • New pages(routes) added
  • New dependencies installed

PR Checklist

  • Pull request is raised from the correct source branch
  • Pull request is raised to the correct destination branch
  • Pull request is raised with correct title
  • Pull request is self reviewed
  • Pull request is self assigned
  • Suitable pull request status labels are added (ready-for-code-review)

Additional Information

@shakila-kamalasena shakila-kamalasena self-assigned this Feb 20, 2026
Copilot AI review requested due to automatic review settings February 20, 2026 05:33
@sonarqubecloud
Copy link

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the Community Settings page header behavior to better match what a user can actually access, particularly when only a single settings tab is visible.

Changes:

  • Adds session + global login method state to derive a conditional Settings page title (e.g., “Integrations” for certain employee SSO cases).
  • Hides the tab bar when there’s only one visible tab.
  • Replaces the hard-coded Settings header title with the derived pageTitle.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@@ -46,18 +63,20 @@ const Settings: NextPage = () => {
return (
<ContentLayout
pageHead={translateText(["pageHead"])}
Copy link

Copilot AI Feb 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ContentLayout uses pageHead for the document <title>, but this page now conditionally changes the visible header title to "Integrations". That can leave the browser tab title saying "Settings | Skapp" while the page H1 says "Integrations". Consider switching pageHead to translateText(["integrationPageHead"]) when shouldShowIntegrationsTitle is true (the translation key already exists).

Suggested change
pageHead={translateText(["pageHead"])}
pageHead={
shouldShowIntegrationsTitle
? translateText(["integrationPageHead"])
: translateText(["pageHead"])
}

Copilot uses AI. Check for mistakes.
Comment on lines +73 to +78
<Tabs
tabs={visibleTabs}
activeTabId={activeTab}
onTabChange={(id) => setActiveTab(id)}
size="lg"
/>
Copy link

Copilot AI Feb 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

activeTab is initialized from visibleTabs[0]?.id only on the first render. If visibleTabs changes later (e.g., after auth/session state resolves or when switching environments/translations), activeTab can remain undefined or point to a tab that is no longer visible, which makes visibleTabs.find(...)? render nothing. Consider syncing activeTab in an effect when visibleTabs changes (e.g., set it to the first tab when it’s unset or no longer present).

Copilot uses AI. Check for mistakes.
@ThinuwanW ThinuwanW merged commit 7dfe447 into develop Feb 20, 2026
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants