Chore: remove skapp ui from main package json#790
Open
hasalarootcode wants to merge 2 commits intomainfrom
Open
Chore: remove skapp ui from main package json#790hasalarootcode wants to merge 2 commits intomainfrom
hasalarootcode wants to merge 2 commits intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes the @rootcodelabs/skapp-ui dependency from the frontend package.json and updates multiple Git submodule references across the codebase.
- Removes the
@rootcodelabs/skapp-uipackage dependency from frontend dependencies - Updates Git submodule commit references across frontend and backend directories
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| frontend/package.json | Removes the @rootcodelabs/skapp-ui dependency from package dependencies |
| frontend/src/enterprise | Updates Git submodule commit reference |
| frontend/pages/enterprise | Updates Git submodule commit reference |
| frontend/pages/api/enterprise | Updates Git submodule commit reference |
| backend/src/test/java/com/skapp/enterprise | Updates Git submodule commit reference |
| backend/src/main/resources/enterprise | Updates Git submodule commit reference |
| backend/src/main/resources/config | Updates Git submodule commit reference |
| backend/src/main/java/com/skapp/enterprise | Updates Git submodule commit reference |
Comments suppressed due to low confidence (1)
frontend/package.json:32
- Removing this dependency could break existing functionality that relies on skapp-ui components. Ensure that all imports and usage of this package have been removed from the codebase and that adequate tests verify the application still functions correctly without this dependency.
"@tanstack/react-query": "^5.74.4",
|
ThinuwanW
approved these changes
Aug 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR checklist
TaskId: (https://github.com/SkappHQ/skapp/issues/[id])
Summary
How to test
Project Checklist
npm run formatnpm run check-lintOther
PR Checklist
ready-for-code-review)Additional Information