Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added memory connector to trino #122

Open
wants to merge 17 commits into
base: master
Choose a base branch
from
Open

Added memory connector to trino #122

wants to merge 17 commits into from

Conversation

pdmthorsrud
Copy link
Contributor

@pdmthorsrud pdmthorsrud commented May 27, 2021

Closes/fixes/resolves issue(s)?

Closes #121

What was added/changed/fixed?

Memory connector properties file

Related issue(s)? [Optional]

Others [Optional]

Checklist (after created PR)

  • Added reviewers
  • Added assignee(s)
  • Added label(s)
  • Added to project
  • Added to milestone

@pdmthorsrud
Copy link
Contributor Author

pdmthorsrud commented May 28, 2021

Pipeline gets an error, but it does not seem to be related to my changes. Also runs fine locally

edit: created issue #124

Copy link
Contributor

@fredrikhgrelland fredrikhgrelland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but some changes required.

There must be links to documentation added, and possibly also a simple example on how/why to use?

conf/nomad/trino.hcl Outdated Show resolved Hide resolved
conf/nomad/trino_standalone.hcl Outdated Show resolved Hide resolved
main.tf Outdated Show resolved Hide resolved
variables.tf Outdated Show resolved Hide resolved
variables.tf Outdated Show resolved Hide resolved
variables.tf Outdated Show resolved Hide resolved
pdmthorsrud and others added 5 commits July 1, 2021 00:08
Co-authored-by: Fredrik Hoem Grelland <40291976+fredrikhgrelland@users.noreply.github.com>
Co-authored-by: Fredrik Hoem Grelland <40291976+fredrikhgrelland@users.noreply.github.com>
Co-authored-by: Fredrik Hoem Grelland <40291976+fredrikhgrelland@users.noreply.github.com>
Co-authored-by: Fredrik Hoem Grelland <40291976+fredrikhgrelland@users.noreply.github.com>
Co-authored-by: Fredrik Hoem Grelland <40291976+fredrikhgrelland@users.noreply.github.com>
@pdmthorsrud
Copy link
Contributor Author

Looks good, but some changes required.

There must be links to documentation added, and possibly also a simple example on how/why to use?

I was thinking its own section would be too much, considering there is no mention of the other connectors (Trino and PostgreSQL), except in the input section.

If we add doc for the memory connector we should add doc for all connectors under a "Connectors" section. I think that is a good idea, WDYT?

edit: god damn I miss github, this site is so clear and concise

@fredrikhgrelland
Copy link
Contributor

Looks good, but some changes required.
There must be links to documentation added, and possibly also a simple example on how/why to use?

I was thinking its own section would be too much, considering there is no mention of the other connectors (Trino and PostgreSQL), except in the input section.

If we add doc for the memory connector we should add doc for all connectors under a "Connectors" section. I think that is a good idea, WDYT?

edit: god damn I miss github, this site is so clear and concise

Yep - a simple and short connectors section with doc links would do it

@fredrikhgrelland
Copy link
Contributor

@pdmthorsrud Abandoned?

@pdmthorsrud
Copy link
Contributor Author

pdmthorsrud commented Aug 5, 2021

@pdmthorsrud Abandoned?

Oh, not abandoned, but most definitely forgotten. I will add the doc section!

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Tom Daniel Grande and others added 2 commits August 13, 2021 08:38
Co-authored-by: Fredrik Hoem Grelland <40291976+fredrikhgrelland@users.noreply.github.com>
Co-authored-by: Fredrik Hoem Grelland <40291976+fredrikhgrelland@users.noreply.github.com>
@fredrikhgrelland
Copy link
Contributor

@tomdgr linter is throwing errors..

@claesgill claesgill removed their request for review September 1, 2021 11:01
@karimacherradi karimacherradi requested review from fredrikhgrelland and removed request for fredrikhgrelland September 22, 2021 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add possibility to use a memory connector with trino
2 participants