-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added memory connector to trino #122
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but some changes required.
There must be links to documentation added, and possibly also a simple example on how/why to use?
Co-authored-by: Fredrik Hoem Grelland <40291976+fredrikhgrelland@users.noreply.github.com>
Co-authored-by: Fredrik Hoem Grelland <40291976+fredrikhgrelland@users.noreply.github.com>
Co-authored-by: Fredrik Hoem Grelland <40291976+fredrikhgrelland@users.noreply.github.com>
Co-authored-by: Fredrik Hoem Grelland <40291976+fredrikhgrelland@users.noreply.github.com>
Co-authored-by: Fredrik Hoem Grelland <40291976+fredrikhgrelland@users.noreply.github.com>
I was thinking its own section would be too much, considering there is no mention of the other connectors (Trino and PostgreSQL), except in the input section. If we add doc for the memory connector we should add doc for all connectors under a "Connectors" section. I think that is a good idea, WDYT? edit: god damn I miss github, this site is so clear and concise |
Yep - a simple and short connectors section with doc links would do it |
@pdmthorsrud Abandoned? |
Oh, not abandoned, but most definitely forgotten. I will add the doc section! |
Co-authored-by: Fredrik Hoem Grelland <40291976+fredrikhgrelland@users.noreply.github.com>
Co-authored-by: Fredrik Hoem Grelland <40291976+fredrikhgrelland@users.noreply.github.com>
@tomdgr linter is throwing errors.. |
Closes/fixes/resolves issue(s)?
Closes #121
What was added/changed/fixed?
Memory connector properties file
Related issue(s)? [Optional]
Others [Optional]
Checklist (after created PR)