Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added jvm and config custom variables #123

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

pdmthorsrud
Copy link
Contributor

@pdmthorsrud pdmthorsrud commented May 27, 2021

Closes/fixes/resolves issue(s)?

Closes #120

What was added/changed/fixed?

Added list variables to add custom configs

Related issue(s)? [Optional]

Others [Optional]

Checklist (after created PR)

  • Added reviewers
  • Added assignee(s)
  • Added label(s)
  • Added to project
  • Added to milestone

@pdmthorsrud pdmthorsrud requested review from zhenik and claesgill May 27, 2021 13:11
@pdmthorsrud pdmthorsrud self-assigned this May 27, 2021
@pdmthorsrud
Copy link
Contributor Author

Error in pipeline, does not seem to be related to my changes.

Created issue here #124

@pdmthorsrud
Copy link
Contributor Author

@claesgill Is this something we can expect that you guys will take a look at, or should we just carry on with our own tag/rc for now? :)

@claesgill
Copy link
Contributor

@pdmthorsrud sorry for the late response, but we are currently understaffed and we're not able to prioritize this issue atm. Is it possible for you or any in your team time to look into #124?

@fredrikhgrelland
Copy link
Contributor

LGTM

Copy link
Contributor

@fredrikhgrelland fredrikhgrelland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update CHANGELOG.md and add links to Trino documentation and it is good to go.

Bonus addition: example on how to extend. Currently, this requires knowledge on how to craft config files.

@pdmthorsrud
Copy link
Contributor Author

Please update CHANGELOG.md and add links to Trino documentation and it is good to go.

Bonus addition: example on how to extend. Currently, this requires knowledge on how to craft config files.

Crap, I totally forgot about this MR too... Totally my bad. I have added links to doc. When you say "how to extend", are you talking about how to add even more files to Trino's configuration if you'd like to contribute?

# Conflicts:
#	CHANGELOG.md
@claesgill claesgill removed their request for review September 1, 2021 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add configuration parameters for jvm.config and config.properties
3 participants