-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added jvm and config custom variables #123
base: master
Are you sure you want to change the base?
Conversation
Error in pipeline, does not seem to be related to my changes. Created issue here #124 |
@claesgill Is this something we can expect that you guys will take a look at, or should we just carry on with our own tag/rc for now? :) |
@pdmthorsrud sorry for the late response, but we are currently understaffed and we're not able to prioritize this issue atm. Is it possible for you or any in your team time to look into #124? |
LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update CHANGELOG.md and add links to Trino documentation and it is good to go.
Bonus addition: example on how to extend. Currently, this requires knowledge on how to craft config files.
Crap, I totally forgot about this MR too... Totally my bad. I have added links to doc. When you say "how to extend", are you talking about how to add even more files to Trino's configuration if you'd like to contribute? |
# Conflicts: # CHANGELOG.md
Closes/fixes/resolves issue(s)?
Closes #120
What was added/changed/fixed?
Added list variables to add custom configs
Related issue(s)? [Optional]
Others [Optional]
Checklist (after created PR)