Set the string flavour tag of the jar in the actions artifacts to nightly

[TheLimeGlass]

Description

Set the string flavour tag of the jar in the actions artifacts to nightly as per @APickledWalrus

[APickledWalrus]

Maybe we should just have tests generate a jar named Skript-nightly? Would remove the need for most of the changes here 🙂

[TheLimeGlass]

Maybe we should just have tests generate a jar named Skript-nightly? Would remove the need for most of the changes here 🙂

Already said in Discord that if the name was Skript-nightly every reference in the Skript code and Skript test runner would need to be changed. I did try that, and it still errored for some reason because the name was Skript-nightly. So for Skript's sake, it only uses Skript.jar, and after the tests are ran, it can be named whatever, and to whatever we decide on later down the road.

[TPGamesNL]

I don't think the tests should be a nightly tasks by default, those are reserved for GH Actions only (IMO we should actually only have them for the ones on the master branch, and a diff flavour for other branches).

I think it'd be better to first run the skriptTest task, than clean nightlyRelease

[TheLimeGlass]

I don't think the tests should be a nightly tasks by default, those are reserved for GH Actions only (IMO we should actually only have them for the ones on the master branch, and a diff flavour for other branches).

I think it'd be better to first run the skriptTest task, than clean nightlyRelease

It was that originally, but Pickle thought otherwise, so it's changed. We need to come up with an agreement.

I think it's perfect at it's current state.

[TheLimeGlass]

I made it so both the Skript-test.jar and Skript-nightly.jar are uploaded in the artifact. It's good to include the actual jar that was used in the tests.

It's Skript-test.jar because in this pull request #4979 I added JUnit dependencies inside the jar, so it's got different classes inside. Skript-nightly is a snapshot of the Skript release at that time, aka a nightly build.