Add exact event checking when converting event-values in last attempt #5171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheLimeGlass
added
bug
APickledWalrus
approved these changes
Oct 21, 2022
Pikachu920
added
the
hacktoberfest-accepted
TPGamesNL
requested changes
Nov 9, 2022
TPGamesNL
requested changes
Nov 10, 2022
AyhamAl-Ali
reviewed
Nov 11, 2022
TPGamesNL
requested changes
Nov 16, 2022
Co-authored-by: TPGamesNL <29547183+TPGamesNL@users.noreply.github.com>
TPGamesNL
approved these changes
Nov 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When Skript can't find an event value that matches the requesting event OR type. It starts attempting to look at other event values and checks if the type is assignable then checks if the event is assignable, but Skript will error in the rare case that the event value is actually of a GREATER subclass than the requesting event of the event-value. In the case of #5016 Skript was grabbing the newly added CraftItemEvent event value (CraftItemEvent extends InventoryClickEvent) rather than InventoryClickEvent event value for ItemStack when requesting an ItemType. So Skript wanted CraftItemEvent ItemStack event value to convert it ItemType but the event was InventoryClickEvent so it threw a method not found error.
There is really only a new loop added, GitHub makes the changes look more than it is.
Target Minecraft Versions: any
Related Issues: #5016 and #5032