Remove StructureType #5473
Closed
Remove StructureType #5473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheLimeGlass
added
the
bug
Merged
Moderocky
force-pushed
the
master
branch
2 times, most recently
from
bd134d0 to
3f08853
Compare
|
Closing due to inactivity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes StructureType. It's only purpose was to allow to define multiple names to one. We can now do all of the trees as it's an enum. Waiting on #4979 so I can actually do some proper tests for this. The reasoning is because we've appeared to forget to add types to this, also to support 1.12 this is the best method.
Target Minecraft Versions: any
Requirements: none
Related Issues: #5425 and #4675