Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test crashing the test server #5547

Closed
wants to merge 2 commits into from
Closed

Conversation

TheLimeGlass
Copy link
Contributor

Description

Potentially fixes the test server from crashing randomly, more information at the related issue.


Target Minecraft Versions: any
Requirements: none
Related Issues: #5546

@TheLimeGlass TheLimeGlass added bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. unit testing For issues/PRs related to the Skript unit testing system. 2.7 Targeting a 2.7.X version release labels Mar 24, 2023
@TheLimeGlass
Copy link
Contributor Author

It fixed the issue, but opened a new one. Great.

@TheLimeGlass TheLimeGlass removed the 2.7 Targeting a 2.7.X version release label Mar 24, 2023
@kiip1
Copy link
Contributor

kiip1 commented Mar 26, 2023

#5225 doesn't seem to have this issue. Quite weird.

@TheLimeGlass
Copy link
Contributor Author

#5225 doesn't seem to have this issue. Quite weird.

it's random. If I restart these failed test it'll work. Main issue is that it's after the tests, so not cleaning up tests causes it.

@Moderocky Moderocky force-pushed the master branch 2 times, most recently from bd134d0 to 3f08853 Compare September 16, 2023 16:59
@Moderocky Moderocky changed the base branch from master to dev/feature September 18, 2023 10:24
@TheLimeGlass TheLimeGlass deleted the fix/tests-crashing branch October 27, 2023 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. unit testing For issues/PRs related to the Skript unit testing system.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants