-
-
Notifications
You must be signed in to change notification settings - Fork 377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Keep items expression and effect #6051
Conversation
2f3794b
to
c90933b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did a minor once through, just some nitpicks and mentions I haven't seen yet
5b667b4
to
808a771
Compare
I am planning to merge EffKeptItems to the EffKeepInventory, I did not realize there was already a keep inventory effect. Also, @Moderocky has pointed out that the syntax of both might need some rewording, so if anyone can come up with different syntaxes for them then I am all ears |
f1fb1b6
to
6bfa7be
Compare
I decided to remove the kept items expression as its behaviour was rather unclear, I could have just renamed it to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still think this is a little wobbly in execution but it's ok.
Co-authored-by: LimeGlass <16087552+TheLimeGlass@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this is implemented properly.
keep inventory
maintains the items in the inventory and still has them in the drops.
keep the dirt
maintains 1 dirt in the inventory and removes 1 dirt from the drops.
keep all dirt
maintains 1 dirt in the inventory and removes it all from the drops
I'd like to see parity between behavior when keeping inventory and keeping specific items, and I think work needs to be done to handle all
better.
I'm also of the opinion that keep dirt
should keep ALL dirt, and keep 1 dirt
should only keep 1 dirt, but I'm not sure if that's feasible.
Closing due to inactivity. |
Description
Adds the missing keep inventory effect and expressions.
Marking it as a draft since I still haven't tested it but want opinion on whether I should add a pattern to not clear the drops for the keep items effect, since that's kind of the whole reason why I added the effect in the first place so that users don't have to do it themselves.
Target Minecraft Versions: 1.13+
Requirements: Paper
Related Issues: N/A