Adds some command block syntax #6859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- An expression to get/set the command of a command block or minecart with command block - An effect and condition for whether a command block is conditional or not - Tests for both
sovdeeth
requested changes
Jul 12, 2024
Co-authored-by: sovdee <10354869+sovdeeth@users.noreply.github.com>
sovdeeth
requested changes
Jul 17, 2024
src/main/java/ch/njol/skript/effects/EffCommandBlockConditional.java
Outdated
Show resolved
Hide resolved
src/main/java/ch/njol/skript/expressions/ExprCommandBlockCommand.java
Outdated
Show resolved
Hide resolved
src/main/java/ch/njol/skript/expressions/ExprCommandBlockCommand.java
Outdated
Show resolved
Hide resolved
src/main/java/ch/njol/skript/expressions/ExprCommandBlockCommand.java
Outdated
Show resolved
Hide resolved
src/main/java/ch/njol/skript/expressions/ExprCommandBlockCommand.java
Outdated
Show resolved
Hide resolved
src/main/java/ch/njol/skript/expressions/ExprCommandBlockCommand.java
Outdated
Show resolved
Hide resolved
src/test/skript/tests/syntaxes/expressions/ExprCommandBlockCommand.sk
Outdated
Show resolved
Hide resolved
sovdeeth
requested changes
Jul 22, 2024
sovdeeth
approved these changes
Jul 22, 2024
Moderocky
requested changes
Aug 17, 2024
src/main/java/ch/njol/skript/expressions/ExprCommandBlockCommand.java
Outdated
Show resolved
Hide resolved
src/main/java/ch/njol/skript/effects/EffCommandBlockConditional.java
Outdated
Show resolved
Hide resolved
Moderocky
approved these changes
Sep 6, 2024
sovdeeth
added
the
feature-ready
UnderscoreTud
approved these changes
Sep 13, 2024
src/main/java/ch/njol/skript/conditions/CondIsCommandBlockConditional.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds:
Target Minecraft Versions: any
Requirements: none
Related Issues: none