Update charged syntax #6860
Merged
Update charged syntax #6860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
can you please add tests? |
- Also deletes old test
- Wither skull wasn't spawning as I thought it was, changed to shoot effect
sovdeeth
requested changes
Jul 12, 2024
sovdeeth
added
the
enhancement
Co-authored-by: sovdee <10354869+sovdeeth@users.noreply.github.com>
sovdeeth
approved these changes
Jul 18, 2024
TheLimeGlass
approved these changes
Jul 21, 2024
| @@ -0,0 +1,31 @@ | |||
| test "is charged": | |||
| spawn a creeper at (spawn of world "world"): | |||
There was a problem hiding this comment.
You can also use event-location in the case that we change the location for some reason.
Moderocky
approved these changes
Aug 17, 2024
Moderocky
added
the
feature-ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds wither skulls to the charged syntaxes (CondIsCharged and EffCharge) and adds a new test.
Target Minecraft Versions: any
Requirements: none
Related Issues: none