Adds entity sound expression and test #7019
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UnderscoreTud
requested changes
Aug 31, 2024
Co-authored-by: _tud <98935832+UnderscoreTud@users.noreply.github.com>
TheLimeGlass
approved these changes
Aug 31, 2024
Moderocky
approved these changes
Aug 31, 2024
- Updates fall damage pattern to not conflict with new block sound PR - Fixes some other patterns missing some small details - Adds Skript doc annotations - Adds new ambient sound
sovdeeth
requested changes
Sep 13, 2024
UnderscoreTud
approved these changes
Sep 13, 2024
sovdeeth
approved these changes
Sep 26, 2024
sovdeeth
added
the
feature-ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds an expression to get a sound of a living entity. The gettable sounds are
death, damage, swim, fall, high fall, fall from x distance, splash, speedy splash, eating, eating with x item, drinking, drinking with x itemTarget Minecraft Versions: 1.19.2 and higher
Requirements: none
Related Issues: none