Adding entity expressions & conditions #7088
Merged
+234
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed EvtPiglinBarter.sk after more research
This comment was marked as resolved.
This comment was marked as resolved.
|
I found it, but thank you! |
cheeezburga
requested changes
Sep 18, 2024
src/main/java/ch/njol/skript/conditions/CondFromMobSpawner.java
Outdated
Show resolved
Hide resolved
src/main/java/ch/njol/skript/conditions/CondFromMobSpawner.java
Outdated
Show resolved
Hide resolved
src/main/java/ch/njol/skript/conditions/CondFromMobSpawner.java
Outdated
Show resolved
Hide resolved
src/main/java/ch/njol/skript/conditions/CondFromMobSpawner.java
Outdated
Show resolved
Hide resolved
src/main/java/ch/njol/skript/conditions/CondFromMobSpawner.java
Outdated
Show resolved
Hide resolved
src/main/java/ch/njol/skript/expressions/ExprCustomNameVisibility.java
Outdated
Show resolved
Hide resolved
cheeezburga
added
enhancement
Efnilite
requested changes
Sep 18, 2024
src/main/java/ch/njol/skript/conditions/CondFromMobSpawner.java
Outdated
Show resolved
Hide resolved
src/main/java/ch/njol/skript/conditions/CondFromMobSpawner.java
Outdated
Show resolved
Hide resolved
src/main/java/ch/njol/skript/conditions/CondIsCustomNameVisible.java
Outdated
Show resolved
Hide resolved
src/main/java/ch/njol/skript/conditions/CondIsCustomNameVisible.java
Outdated
Show resolved
Hide resolved
src/main/java/ch/njol/skript/expressions/ExprCustomNameVisibility.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Efy <35348263+Efnilite@users.noreply.github.com>
Added EffCustomName Added EffCustomName test Removed ExprCustomNameVisibility.java Fixed ParseResult import
cheeezburga
requested changes
Sep 19, 2024
Nuutrai
commented
Sep 19, 2024
Co-authored-by: cheeezburga <47320303+cheeezburga@users.noreply.github.com>
|
Please do not add any more syntaxes than what you have to this pr, and for future additions try to keep prs focused on a single topic. Working on that todo list is great but we want the prs to be small and focused so that issues with one part don't slow down other parts that are good to go! |
Alrighty! I'll work on the test for CondIsTicking (since it's a little hard to test CondFromMobSpawner), then I'll mark the pr as ready for review. (Let me know if any of the other things need tests or anything!) |
sovdeeth
requested changes
Sep 19, 2024
src/main/java/ch/njol/skript/conditions/CondFromMobSpawner.java
Outdated
Show resolved
Hide resolved
sovdeeth
requested changes
Sep 19, 2024
src/main/java/ch/njol/skript/conditions/CondFromMobSpawner.java
Outdated
Show resolved
Hide resolved
src/main/java/ch/njol/skript/expressions/ExprFireDamageDelay.java
Outdated
Show resolved
Hide resolved
sovdeeth
requested changes
Sep 21, 2024
src/main/java/ch/njol/skript/conditions/CondFromMobSpawner.java
Outdated
Show resolved
Hide resolved
Efnilite
requested changes
Sep 23, 2024
src/main/java/ch/njol/skript/conditions/CondFromMobSpawner.java
Outdated
Show resolved
Hide resolved
src/main/java/ch/njol/skript/conditions/CondIsCustomNameVisible.java
Outdated
Show resolved
Hide resolved
src/main/java/ch/njol/skript/conditions/CondIsCustomNameVisible.java
Outdated
Show resolved
Hide resolved
src/main/java/ch/njol/skript/conditions/CondFromMobSpawner.java
Outdated
Show resolved
Hide resolved
Efnilite
approved these changes
Sep 25, 2024
ShaneBeee
reviewed
Sep 29, 2024
ShaneBeee
reviewed
Sep 29, 2024
sovdeeth
approved these changes
Oct 3, 2024
cheeezburga
approved these changes
Oct 9, 2024
cheeezburga
added
the
feature-ready
Nuutrai
changed the title
Moderocky
approved these changes
Nov 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I've added most of the remaining features on the entity section (forgot to mention that when initially posting) todo list, however I'll continue trying to work on the ones remaining
Target Minecraft Versions: any
Requirements: none
Related Issues: Todo List (#4185)
Let me know if you have any suggestions such as syntax (I know syntax will probably want to be changed).