Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Operators reloading info" #7102

Conversation

EquipableMC
Copy link
Contributor

@EquipableMC EquipableMC commented Sep 21, 2024

Reverts #6780

Reverts this pull request as there is message issues that went unnoticed.
Ingame:
image
CONSOLE
image

@AyhamAl-Ali
Copy link
Member

No need to revert the whole thing, just fix it 💅

@EquipableMC
Copy link
Contributor Author

EquipableMC commented Sep 21, 2024

No need to revert the whole thing, just fix it 💅

True, but this seems to be a bigger issue then I know with my experience in Java (RedirectingLogHandler). So I figured reverting it, then someone can make a new PR which implements it better with working messages.
Edit:
To add onto this, there should of been testing done. I usually ALWAYS test my PRs before I even commit changes and what not. I am unsure as to how this testing went unnoticed.

@sovdeeth
Copy link
Member

It's on dev/feature, there's no rush and no need to revert it.

@EquipableMC
Copy link
Contributor Author

It's on dev/feature, there's no rush and no need to revert it.

True, should I open an issue instead?

@AyhamAl-Ali
Copy link
Member

It's on dev/feature, there's no rush and no need to revert it.

Adding to that it's not a breaking change and can be easily hot-fixed by removing the permission from recipients. Either open a new issue or open a new PR with a fix.

@EquipableMC EquipableMC deleted the revert-6780-addition-operators-reloading-info branch September 21, 2024 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants