Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slight Exception message changes #7116

Open
wants to merge 12 commits into
base: dev/patch
Choose a base branch
from

Conversation

Asleeepp
Copy link
Contributor

@Asleeepp Asleeepp commented Sep 27, 2024

Description

Honestly, I'm not really the biggest fan of how the exception is laid out, especially lines 1759-1763, and the constant "You'll be given instructions on how to report this", but I'd rather not change that.
This PR aims to fix some punctation errors I found, and also reword some sentences.


Target Minecraft Versions: any
Requirements: none
Related Issues: none

@sovdeeth sovdeeth added the enhancement Feature request, an issue about something that could be improved, or a PR improving something. label Sep 27, 2024
src/main/java/ch/njol/skript/Skript.java Outdated Show resolved Hide resolved
src/main/java/ch/njol/skript/Skript.java Outdated Show resolved Hide resolved
@Asleeepp Asleeepp requested a review from Efnilite September 28, 2024 16:38
src/main/java/ch/njol/skript/Skript.java Outdated Show resolved Hide resolved
src/main/java/ch/njol/skript/Skript.java Outdated Show resolved Hide resolved
src/main/java/ch/njol/skript/Skript.java Outdated Show resolved Hide resolved
src/main/java/ch/njol/skript/Skript.java Outdated Show resolved Hide resolved
@Asleeepp Asleeepp requested a review from sovdeeth October 3, 2024 21:54
Copy link
Member

@APickledWalrus APickledWalrus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some brief thoughts. I like the idea here

src/main/java/ch/njol/skript/Skript.java Outdated Show resolved Hide resolved
src/main/java/ch/njol/skript/Skript.java Outdated Show resolved Hide resolved
src/main/java/ch/njol/skript/Skript.java Outdated Show resolved Hide resolved
Copy link
Member

@sovdeeth sovdeeth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good with pickle's changes

@sovdeeth sovdeeth added the 2.10 Targeting a 2.10.X version release label Dec 17, 2024
Copy link
Contributor

@TheAbsolutionism TheAbsolutionism left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just because 😁

Asleeepp and others added 2 commits December 29, 2024 19:16
Co-authored-by: SirSmurfy2 <82696841+TheAbsolutionism@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.10 Targeting a 2.10.X version release enhancement Feature request, an issue about something that could be improved, or a PR improving something.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants