Make KeyValueEntryData validation not case-sensitive #7143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erenkarakal
changed the title
Efnilite
approved these changes
Oct 12, 2024
Efnilite
added
bug
sovdeeth
approved these changes
Oct 12, 2024
UnderscoreTud
approved these changes
Oct 12, 2024
src/main/java/org/skriptlang/skript/lang/entry/KeyValueEntryData.java
Outdated
Show resolved
Hide resolved
Co-authored-by: _tud <98935832+UnderscoreTud@users.noreply.github.com>
sovdeeth
added
the
patch-ready
APickledWalrus
requested changes
Oct 13, 2024
There was a problem hiding this comment.
This probably needs done for the other canCreateWith implementations
You might also prefer using https://docs.oracle.com/en/java/javase/11/docs/api/java.base/java/lang/String.html#regionMatches(boolean,int,java.lang.String,int,int)
sovdeeth
removed
the
patch-ready
…to patch/entry-case-sensitivity # Conflicts: # src/main/java/org/skriptlang/skript/lang/entry/KeyValueEntryData.java
other implementations seem to be ignoring text cases already |
APickledWalrus
approved these changes
Oct 29, 2024
Efnilite
added
feature-ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR makes all entries in KeyValueEntryData's lowercase when comparing.
Target Minecraft Versions: any
Requirements: none
Related Issues: #7138