Delete SoundUtils to fix building #7196
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
APickledWalrus
added
bug
Efnilite
approved these changes
Nov 5, 2024
sovdeeth
approved these changes
Nov 5, 2024
|
As far as I can see, the tests are still failing due to |
|
Ah yeah ill push a fix later today |
|
Closing in favor of #7199 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to fix build failures caused by Sound no longer being an enum. I deleted the class outright as it is unused and has no functionality (the necessary lang entries do not exist).
Target Minecraft Versions: any
Requirements: none
Related Issues: none