Adds Loot Tables

[Burbulinis]

Description

Adds loot tables and loot generation to Skript.

---

Target Minecraft Versions: any
Requirements: none
Related Issues: #5937

[Moderocky]

Good start :)

[Asleeepp]

tests tests tests!!!

[Fusezion]

Just to cause more mayham, wanna make this a module?

[Fusezion]

After talking a bit with someone else and getting their feedback on a suggestion I wanna post it here for you as well.

What's the thought about making a wrapper class for the loot context similar to how recipes were done?

Currently every time you wanna change the syntax you end up doing new builder -> copy old stats -> add new stat for each of the stats in other words

ExprLootContextWithEntity -> new -> edit entity -> return
ExprLootContextWithKiller -> new -> edit killer -> return
ExprLootContextWithLuck   -> new -> edit luck   -> return

Due to this you ended up with two expressions for the same things
ExprLootContextWithX and ExprLootContextX these could be merged into 1 expression allowing changers and using a wrapper around LootContext with methods for setting the values you can do something like

LootContextWrapper#setKiller
LootContextWrapper#setLuck
LootContextWrapper#setEntity

Hell you could probably even change the loot context location. This addition will also allow the usage of a Secpression meaning we could instead see syntax like

set {_plank} to a new loot context:
    set loot context entity to {_player}
    set loot context luck to 10
    set loot context killer to {_players twin brother}
    set loot context location to location({_x},-5,10, "World")

[sovdeeth]

A lot of the syntaxes are worryingly generic. As a specific example, I can see people getting very confused with killer of {_thing}. I would prefer a lot of these to have required keywords that make sure they don't conflict/get confused with other syntaxes.

[Efnilite]

Looking good, your test files need to end with new lines though :)

[Fusezion]

I didn't look at changers and I removed things that mentioned to use Loottabletypes until they're added back for for a first look it's good. I really wish github didn't force line breaks on long lines

[TheAbsolutionism]

Slight look over.

[APickledWalrus]

This is looking really good. Great work so far!

[TheAbsolutionism]

Some nitpick things

[APickledWalrus]

Should be the final changes 🥳

[APickledWalrus]

You have done an excellent job. Great work!!

[Burbulinis]

You have done an excellent job. Great work!!

thank you pickel :)

[TheAbsolutionism]

Looks to be the last few things.