Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

String Colors #7276

Open
wants to merge 11 commits into
base: dev/feature
Choose a base branch
from
Open

String Colors #7276

wants to merge 11 commits into from
+236 −37

Conversation

TheAbsolutionism
Copy link
Contributor

@TheAbsolutionism TheAbsolutionism commented Dec 18, 2024 •
edited
Loading

Description

This PR aims to rework ExprLastColors to allow users to get all, the first or the last color object or color code of a colored string.

This will technically be a breaking change, but it's minor imo, and for the better.

Target Minecraft Versions: any
Requirements: none
Related Issues: #5040

@Efnilite Efnilite added the enhancement Feature request, an issue about something that could be improved, or a PR improving something. label Dec 18, 2024
sovdeeth
sovdeeth requested changes Dec 18, 2024
View reviewed changes
src/main/java/ch/njol/skript/expressions/ExprStringColor.java Outdated Show resolved Hide resolved
src/main/java/ch/njol/skript/expressions/ExprStringColor.java Outdated Show resolved Hide resolved
src/main/java/ch/njol/skript/expressions/ExprStringColor.java Outdated Show resolved Hide resolved
src/main/java/ch/njol/skript/expressions/ExprStringColor.java Outdated Show resolved Hide resolved
src/main/java/ch/njol/skript/util/SkriptColor.java Outdated Show resolved Hide resolved
src/main/java/ch/njol/skript/expressions/ExprStringColor.java Outdated Show resolved Hide resolved
src/main/java/ch/njol/skript/expressions/ExprStringColor.java Outdated Show resolved Hide resolved
src/main/java/ch/njol/skript/expressions/ExprStringColor.java Outdated Show resolved Hide resolved
@TheAbsolutionism
Requested Changes
f22a4ea
@TheAbsolutionism
Merge remote-tracking branch 'upstream/dev/feature' into dev/StringCo…
34a505d 
…lors

# Conflicts:
#	src/main/java/ch/njol/skript/expressions/ExprLastColor.java
@Efnilite Efnilite added feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version. 2.11 Targeting a 2.11.X version release labels Jan 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sovdeeth sovdeeth sovdeeth approved these changes

@Efnilite Efnilite Efnilite approved these changes

Assignees
No one assigned
Labels
2.11 Targeting a 2.11.X version release enhancement Feature request, an issue about something that could be improved, or a PR improving something. feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TheAbsolutionism @sovdeeth @Efnilite