Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'sk test' command upgrades #7308

Merged

Conversation

ShaneBeee
Copy link
Contributor

@ShaneBeee ShaneBeee commented Dec 23, 2024

Description

This PR aims to enhance the /sk test command:

  • Add test script names to tab complete (from the Test script directory):
Screenshot 2024-12-23 at 1 56 06 PM
  • Allow using /sk test all to run all of your test scripts:
Screenshot 2024-12-23 at 1 56 52 PM
  • Allow running tests for a directory:
Screenshot 2024-12-23 at 2 08 39 PM
  • Log results to file (since the result path is required, let's use it):
Screenshot 2024-12-23 at 2 46 30 PM
  • Use pretty printing for json output (easier to read than one super long line):
    (This is both for the test command as well as regular test runs)
    BEFORE:
Screenshot 2024-12-23 at 3 21 48 PM

AFTER:
Screenshot 2024-12-23 at 3 19 45 PM

  • Fix a unicode character issue in the outputs:
    BEFORE:
Screenshot 2024-12-23 at 3 24 37 PM

AFTER:
Screenshot 2024-12-23 at 3 24 58 PM

  • Added some color to the command output (thanks to Sovde's suggestion):
Screenshot 2024-12-26 at 3 16 36 PM

Target Minecraft Versions: any
Requirements: none
Related Issues: none

Copy link
Member

@Efnilite Efnilite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

src/main/java/ch/njol/skript/SkriptCommand.java Outdated Show resolved Hide resolved
@Efnilite Efnilite added the enhancement Feature request, an issue about something that could be improved, or a PR improving something. label Dec 24, 2024
@cheeezburga cheeezburga added the feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version. label Dec 27, 2024
src/main/java/ch/njol/skript/SkriptCommand.java Outdated Show resolved Hide resolved
src/main/java/ch/njol/skript/SkriptCommand.java Outdated Show resolved Hide resolved
@Efnilite Efnilite merged commit bc0c5ee into SkriptLang:dev/feature Dec 29, 2024
5 checks passed
@ShaneBeee ShaneBeee deleted the shane/test-mode-auto-complete branch December 29, 2024 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature request, an issue about something that could be improved, or a PR improving something. feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants