Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warden+ #7314

Open
wants to merge 10 commits into
base: dev/feature
Choose a base branch
from
Open

Warden+ #7314

wants to merge 10 commits into from
+276 −0

Conversation

TheAbsolutionism
Copy link
Contributor

@TheAbsolutionism TheAbsolutionism commented Dec 27, 2024 •
edited
Loading

Description

This PR aims to add additional control over Wardens. Allowing users to set a wardens anger level towards an entity and make them sense a disturbance.

Target Minecraft Versions: any
Requirements: none
Related Issues: none

@Efnilite Efnilite added the enhancement Feature request, an issue about something that could be improved, or a PR improving something. label Dec 27, 2024
ShaneBeee
ShaneBeee suggested changes Dec 27, 2024
View reviewed changes
Copy link
Contributor

@ShaneBeee ShaneBeee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple small things

src/main/java/ch/njol/skript/effects/EffWardenDisturbance.java Outdated Show resolved Hide resolved
src/main/java/ch/njol/skript/expressions/ExprWardenAngryAt.java Outdated Show resolved Hide resolved
src/main/java/ch/njol/skript/expressions/ExprWardenEntityAnger.java Outdated Show resolved Hide resolved
@TheAbsolutionism @ShaneBeee
Update src/main/java/ch/njol/skript/effects/EffWardenDisturbance.java
f34e317 
Co-authored-by: Shane Bee <shanebolenback@me.com>
ShaneBeee
ShaneBeee approved these changes Dec 27, 2024
View reviewed changes
Copy link
Contributor

@ShaneBeee ShaneBeee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here's my approval... for sport!

cheeezburga
cheeezburga requested changes Dec 27, 2024
View reviewed changes
Copy link
Member

@cheeezburga cheeezburga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking real good.

src/main/java/ch/njol/skript/effects/EffWardenDisturbance.java Outdated Show resolved Hide resolved
src/main/java/ch/njol/skript/expressions/ExprWardenAngryAt.java Outdated Show resolved Hide resolved
src/test/skript/tests/syntaxes/expressions/ExprWardenEntityAnger.sk Outdated Show resolved Hide resolved
@Efnilite Efnilite added feature Pull request adding a new feature. and removed enhancement Feature request, an issue about something that could be improved, or a PR improving something. labels Dec 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Efnilite Efnilite Efnilite approved these changes

@ShaneBeee ShaneBeee ShaneBeee approved these changes

@cheeezburga cheeezburga Awaiting requested review from cheeezburga

@sovdeeth sovdeeth Awaiting requested review from sovdeeth

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
feature Pull request adding a new feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@TheAbsolutionism @sovdeeth @ShaneBeee @Efnilite @cheeezburga