Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ExprVillagerLevel - add experience #7318

Merged
merged 11 commits into from
Dec 29, 2024

Conversation

ShaneBeee
Copy link
Contributor

Description

This PR aims to add villager experience to the villager level expression.
I forgot to do this when I did the Villager PR


Target Minecraft Versions: any
Requirements: none
Related Issues: none

Copy link
Member

@cheeezburga cheeezburga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could maybe add some more tests for experience (adding, removing, going below 0, etc.), but looks good!

@Efnilite Efnilite added enhancement Feature request, an issue about something that could be improved, or a PR improving something. feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version. labels Dec 27, 2024
@ShaneBeee ShaneBeee requested a review from sovdeeth December 28, 2024 19:00
@Efnilite Efnilite merged commit b7bf646 into SkriptLang:dev/feature Dec 29, 2024
5 checks passed
@ShaneBeee ShaneBeee deleted the shane/villager-exp branch December 29, 2024 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature request, an issue about something that could be improved, or a PR improving something. feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants