Allay Support #7358
Allay Support #7358
Conversation
src/main/java/ch/njol/skript/conditions/CondAllayCanDuplicate.java
Outdated
Show resolved
Hide resolved
src/main/java/ch/njol/skript/expressions/ExprDuplicateCooldown.java
Outdated
Show resolved
Hide resolved
src/main/java/ch/njol/skript/expressions/ExprDuplicateCooldown.java
Outdated
Show resolved
Hide resolved
src/test/skript/tests/syntaxes/expressions/ExprDuplicateCooldown.sk
Outdated
Show resolved
Hide resolved
src/main/java/ch/njol/skript/expressions/ExprDuplicateCooldown.java
Outdated
Show resolved
Hide resolved
src/test/skript/tests/syntaxes/expressions/ExprDuplicateCooldown.sk
Outdated
Show resolved
Hide resolved
| @@ -0,0 +1,15 @@ | |||
| test "allay dancing": | |||
There was a problem hiding this comment.
I left a comment on your initial request for piglins explaining why there were no tests
There was a problem hiding this comment.
Well, it failing is a bit concerning. How were you testing?
There was a problem hiding this comment.
Exact same test as the allay. Just spawn a piglin instead and change the fail messages. I've tested manually, the exact same way as done through the test and it works.
There was a problem hiding this comment.
By manually, do you mean running that exact trigger? or running a similar trigger? or using effect commands?
There was a problem hiding this comment.
effect commands and exact code within a /test command
There was a problem hiding this comment.
The exact code in a test command didn't fail? If that doesn't fail, the test shouldn't either. Perhaps it's a chunk loading thing like we saw a while back
Description
This PR aims to add support for Allays. Allowing users to duplicate allays, set if allays can duplicate naturally, make them dance, duplication cooldown, and their target jukebox.
Target Minecraft Versions: any
Requirements: none
Related Issues: none