Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix super entity changer with location #7394

Open
wants to merge 4 commits into
base: dev/feature
Choose a base branch
from

Conversation

TheLimeGlass
Copy link
Contributor

@TheLimeGlass TheLimeGlass commented Jan 5, 2025

Description

  • Adds INTERNAL change mode for the cases where the change mode gets applied again.
  • Fixes modification of an entity' location not actually applying.
  • Fixes ExprCoordinate's TriggerItem exiting a loop when a variable throws UnsupportedOperationException during conversion. (This currently still silently errors (not at the fault of the PR), this is bad. There are probably other parts of Skript that don't properly handle change, will address in a new issue)

Notes:

  • Tests cannot be applied due to entity teleportation being a tick later.
  • Local variables don't remember their source expression currently. Somewhere in the new conversion system, the source gets lost. This means the original issue of using a variable doesn't work, but using the raw expression last spawned wither will work now. Re-add local variable type hints #5457 adds a solution to this. Example is the source of the variable {_wither} should be the entity, but the source is always the converted Location.

Target Minecraft Versions: any
Requirements: none
Related Issues: #6686

@TheLimeGlass TheLimeGlass added the bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. label Jan 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An issue that needs to be fixed. Alternatively, a PR fixing an issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant