Skip to content

Fix Example Scripts #7430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

APickledWalrus
Copy link
Member

@APickledWalrus APickledWalrus commented Jan 13, 2025

Description

This PR aims to fix multiple errors caused by syntax changes over the past few versions within the example scripts. I have switched from using aliases to using tags (and updated a few examples to accommodate that). The changes to the ore example are due to the fact that a global "ores" tag only exists on Paper.

I have also updated the testing method to now load the example scripts, meaning any example script errors will cause a failure.


Target Minecraft Versions: any
Requirements: none
Related Issues:

@APickledWalrus APickledWalrus added bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. enhancement Feature request, an issue about something that could be improved, or a PR improving something. 2.10 labels Jan 13, 2025
@APickledWalrus APickledWalrus force-pushed the patch/example-scripts-updates branch from 2394423 to 5afa624 Compare January 13, 2025 22:13
@APickledWalrus APickledWalrus merged commit 3cd76aa into SkriptLang:dev/feature Jan 15, 2025
5 checks passed
@APickledWalrus APickledWalrus deleted the patch/example-scripts-updates branch January 15, 2025 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. enhancement Feature request, an issue about something that could be improved, or a PR improving something.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants