Inline Durability/Damaged Item#7438
Closed
NagasonicDev wants to merge 19 commits intoSkriptLang:dev/featurefrom
Closed
Inline Durability/Damaged Item#7438NagasonicDev wants to merge 19 commits intoSkriptLang:dev/featurefrom
NagasonicDev wants to merge 19 commits intoSkriptLang:dev/featurefrom
Conversation
Fusezion
suggested changes
Jan 15, 2025
Contributor
Fusezion
left a comment
Fusezion
left a comment
There was a problem hiding this comment.
Just a quick once through
Co-authored-by: Fusezion <fusezionstream@gmail.com>
Author
|
Changes are taken into account, I will fix shortly. Thanks for your review. (I'm not very good with English for the description stuff) |
TheLimeGlass
suggested changes
Jan 15, 2025
Contributor
|
Thank you for your first contribution to Skript |
Co-authored-by: LimeGlass <16087552+TheLimeGlass@users.noreply.github.com>
Co-authored-by: LimeGlass <16087552+TheLimeGlass@users.noreply.github.com>
Co-authored-by: LimeGlass <16087552+TheLimeGlass@users.noreply.github.com>
Co-authored-by: LimeGlass <16087552+TheLimeGlass@users.noreply.github.com>
Co-authored-by: LimeGlass <16087552+TheLimeGlass@users.noreply.github.com>
Co-authored-by: LimeGlass <16087552+TheLimeGlass@users.noreply.github.com>
Why remove the '@'? Co-authored-by: LimeGlass <16087552+TheLimeGlass@users.noreply.github.com>
Co-authored-by: LimeGlass <16087552+TheLimeGlass@users.noreply.github.com>
Author
|
That should fix everything. No unused imports. Only things that need to be checked are the |
Efnilite
added
the
enhancement
TheLimeGlass
approved these changes
Jan 15, 2025
Co-authored-by: LimeGlass <16087552+TheLimeGlass@users.noreply.github.com>
Co-authored-by: Efnilite <35348263+Efnilite@users.noreply.github.com>
Co-authored-by: Efnilite <35348263+Efnilite@users.noreply.github.com>
Co-authored-by: Efnilite <35348263+Efnilite@users.noreply.github.com>
Efnilite
approved these changes
Jan 28, 2025
sovdeeth
requested changes
Feb 2, 2025
Comment on lines
+52
to
+54
| if (matchedPattern == 0) { | ||
| Skript.warning("Data value is deprecated and is only used in older Minecraft versions that do not support this Skript version."); | ||
| } |
Member
There was a problem hiding this comment.
this needs to check they actually used 'data' and didn't just use with damage 5
skriptlang-automation
bot
added
needs reviews
Member
|
Do you still intend to work on this? |
Absolutionism
approved these changes
Jun 14, 2025
Member
|
Closing due to inactivity |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to durability reverse with the ExprDamagedItem class (#6109 )
Notes:
Target Minecraft Versions: any
Requirements: none
Related Issues: none