-
-
Notifications
You must be signed in to change notification settings - Fork 390
Examples for the experimental features. #7444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Examples for the experimental features. #7444
Conversation
src/main/resources/scripts/-examples/experimental features/for loops.sk
Outdated
Show resolved
Hide resolved
src/main/resources/scripts/-examples/experimental features/script reflection.sk
Outdated
Show resolved
Hide resolved
src/main/resources/scripts/-examples/experimental features/script reflection.sk
Show resolved
Hide resolved
42b8280
to
afc1fb1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice changes, a couple things
src/main/resources/scripts/-examples/experimental features/for loops.sk
Outdated
Show resolved
Hide resolved
afc1fb1
to
7de8c36
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Content seems okay. Seems like a few typos need fixed (test failures) (and Queue was throwing an assertion error? check logs)
… loops.sk Co-authored-by: Patrick Miller <apickledwalrus@gmail.com>
73d9b0e
to
9bcd43c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some indentation inconsistencies between files but looks good
Description
To help give testers some initiative, I've created some example scripts for
2.10
's experimental features (queues, for each loops, script reflection).I've also tweaked an issue I noticed with queues (namely, you couldn't loop them as a variable since they looked like a single value). I think this issue is probably more widespread (any containerised value) but that will need investigating later.
I added a new structure specifically for examples:
example
!Code in this structure is parsed (so examples would still report parse errors) but the code is discarded and never run.
This can be used to set up little code snippet examples, without needing to create some involved structure.
The existing example scripts all have to be whole things (events, commands, etc.) and it can be quite complicated to make a clean example for some features. I'm hoping this will encourage some more introductory content to be made.