ExperimentalSyntax #7575
Merged
ExperimentalSyntax #7575
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sovdeeth
added
the
enhancement
Fusezion
suggested changes
Feb 2, 2025
Pikachu920
previously requested changes
Feb 3, 2025
src/main/java/ch/njol/skript/lang/ExperimentRestrictedSyntax.java
Outdated
Show resolved
Hide resolved
cheeezburga
approved these changes
Feb 3, 2025
I agree with this. I would also have it extend SyntaxElement |
|
This should use the Experiment class instead of the Feature implementation, so it's useful outside Skript's experiments. |
Pesekjak
approved these changes
Feb 10, 2025
Efnilite
approved these changes
Feb 12, 2025
sovdeeth
requested changes
Feb 16, 2025
Fusezion
approved these changes
Mar 9, 2025
sovdeeth
approved these changes
Mar 15, 2025
Efnilite
added
the
feature-ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to add a new interface that syntax elements can implement to state that the element requires an experiment to be enabled in order to use it.
Also gives a proper message on why the line is erroring and informs users on how to use it.
I plan on picking back up my
Tool ComponentsandEquippable ComponentsPRs making them experimental. Since it seems that they may not ever come out of experimental with Minecraft adding stuff almost each version. So this would help with that.Target Minecraft Versions: any
Requirements: none
Related Issues: none