-
-
Notifications
You must be signed in to change notification settings - Fork 407
Setters for Event Locations in Teleport Events #8197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Absolutionism
merged 7 commits into
SkriptLang:dev/feature
from
NotSoDelayed:feature/player-portal-location-changer
Sep 23, 2025
Merged
Setters for Event Locations in Teleport Events #8197
Absolutionism
merged 7 commits into
SkriptLang:dev/feature
from
NotSoDelayed:feature/player-portal-location-changer
Sep 23, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Absolutionism
requested changes
Sep 19, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think these should be moved to EvtMoveOn
sovdeeth
approved these changes
Sep 19, 2025
1 task
Efnilite
approved these changes
Sep 20, 2025
sovdeeth
approved these changes
Sep 21, 2025
Absolutionism
approved these changes
Sep 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
completed
The issue has been fully resolved and the change will be in the next Skript update.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Skript does not have a way to manipulate event locations for teleport related events.
Solution
This PR adds support for modifying said event values.
Additionally, I have unified PlayerPortalEvent and EntityPortalEvent into a single event class which also allows for a unified Skript documentation, as the core event logic of these events are exactly the same.
Testing Completed
My main objective prior to discovering the absence of these changers is to intercept portal usage to divert entities to another location. Specifically, I have a separate world that is for SMP, while also using the default nether world (world_nether). When you are returning from the nether, Minecraft will always send you to the main world instead of the origin world of the player previously came from.
The following code was used for testing:
Results before the change:

Results after the change:
skript-portal-poc.mp4
Supporting Information
Completes: none
Related: #5624