Skip to content

Conversation

sovdeeth
Copy link
Member

Problem

Having a section expression in a function call would not properly claim the section, leading to the section never running:

function f(x: worldborder):
    broadcast "%worldborder warning time of {_x}%"

load:
    f(a worldborder):
        set worldborder warning time to 20 ticks

would broadcast 15 seconds, not 1 second.

Solution

Modifies sectioncontext when parsing EffFunctionCall, so the expr sec can properly claim the section.

Testing Completed

Added a regression test.

Supporting Information


Completes: none
Related: none

@sovdeeth sovdeeth requested review from a team as code owners September 21, 2025 02:16
@sovdeeth sovdeeth added the bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. label Sep 21, 2025
@sovdeeth sovdeeth requested review from UnderscoreTud and Burbulinis and removed request for a team September 21, 2025 02:16
@skriptlang-automation skriptlang-automation bot added the needs reviews A PR that needs additional reviews label Sep 21, 2025
@sovdeeth sovdeeth moved this to In Review in 2.13 Releases Sep 21, 2025
@skriptlang-automation skriptlang-automation bot added the patch-ready A PR/issue that has been approved and is ready to be merged/closed for the next patch version. label Sep 21, 2025
@github-project-automation github-project-automation bot moved this from In Review to Awaiting Merge in 2.13 Releases Sep 21, 2025
@skriptlang-automation skriptlang-automation bot removed the needs reviews A PR that needs additional reviews label Sep 21, 2025
@sovdeeth sovdeeth merged commit 8dd18bc into SkriptLang:dev/patch Sep 21, 2025
5 checks passed
@github-project-automation github-project-automation bot moved this from Awaiting Merge to Done - Awaiting Release in 2.13 Releases Sep 21, 2025
@skriptlang-automation skriptlang-automation bot added completed The issue has been fully resolved and the change will be in the next Skript update. and removed patch-ready A PR/issue that has been approved and is ready to be merged/closed for the next patch version. labels Sep 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. completed The issue has been fully resolved and the change will be in the next Skript update.
Projects
Status: Done - Awaiting Release
Development

Successfully merging this pull request may close these issues.

3 participants