[NO JIRA] Fix button types (#3033)

* Fix button types * fix button import
Skyscanner · Oct 9, 2023 · 15eb563 · 15eb563
1 parent 1caefe5
commit 15eb563
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/packages/bpk-component-button/index.d.ts b/packages/bpk-component-button/index.d.ts
@@ -16,7 +16,7 @@
  * limitations under the License.
  */
 
-import BpkButtonV2 from './src/BpkButtonV2/BpkButton';
+import { BpkButtonV2 } from './src/BpkButtonV2/BpkButton';
 export { BUTTON_TYPES, SIZE_TYPES } from './src/BpkButtonV2/common-types';
 
 export {

diff --git a/packages/bpk-component-button/src/BpkButtonV2/common-types.d.ts b/packages/bpk-component-button/src/BpkButtonV2/common-types.d.ts
@@ -42,7 +42,7 @@ export type Props = {
   className?: string | null;
   disabled?: boolean;
   iconOnly?: boolean;
-  onClick?: (event: MouseEvent<any>) => void;
+  onClick?: (event: MouseEvent<HTMLButtonElement|HTMLAnchorElement>) => void;
   rel?: string | undefined;
   submit?: boolean;
   href?: string | null;

diff --git a/packages/bpk-component-button/src/BpkButtonV2/common-types.tsx b/packages/bpk-component-button/src/BpkButtonV2/common-types.tsx
@@ -45,7 +45,7 @@ export type Props = {
   className?: string | null;
   disabled?: boolean;
   iconOnly?: boolean;
-  onClick?: (event: MouseEvent<any>) => void; // TODO: We need to check this and make this more specific
+  onClick?: (event: MouseEvent<HTMLButtonElement|HTMLAnchorElement>) => void;
   rel?: string | undefined;
   submit?: boolean;
   href?: string | null;