Skip to content

Commit

Permalink
version 0.2.0
Browse files Browse the repository at this point in the history
  • Loading branch information
Slava0135 committed Oct 14, 2024
1 parent 0163c93 commit d89b6ce
Show file tree
Hide file tree
Showing 9 changed files with 137 additions and 6 deletions.
2 changes: 1 addition & 1 deletion Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion Cargo.toml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[package]
name = "n3on-diff"
version = "0.1.0"
version = "0.2.0"
edition = "2021"

# See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html
Expand Down
10 changes: 6 additions & 4 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -39,11 +39,13 @@ Instead, find `*.metadata` files, where outputs for both VMs are saved and encod

## Issues Found

In case you found new VM bugs using this fuzzer, __please__ make an issue and add the link here!
In case you find new VM bugs using this fuzzer, __please__ make an issue and add the link here!

- [MODMUL operation returns wrong results for negative numbers](https://github.com/nspcc-dev/neo-go/issues/3598)
- [MODPOW operation returns wrong results when base is negative](https://github.com/nspcc-dev/neo-go/issues/3612)
- [PACKMAP operation keeps duplicate entries](https://github.com/nspcc-dev/neo-go/issues/3613)
| Name | Description | Link |
| ------------------------------------------------------------ | ------------------------------------ | ------------------------------------------------------- |
| MODMUL operation returns wrong results for negative numbers | [Description](./bugs/neo-go-3598.md) | [Link](https://github.com/nspcc-dev/neo-go/issues/3598) |
| MODPOW operation returns wrong results when base is negative | [Description](./bugs/neo-go-3612.md) | [Link](https://github.com/nspcc-dev/neo-go/issues/3612) |
| PACKMAP operation keeps duplicate entries | [Description](./bugs/neo-go-3613.md) | [Link](https://github.com/nspcc-dev/neo-go/issues/3613) |

## License

Expand Down
29 changes: 29 additions & 0 deletions bugs/neo-go-3598.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
# MODMUL operation returns wrong results for negative numbers

## Minimal case

```text
AGQA/wClpQ==
```

## What is wrong

For negative numbers MODMUL operation returns wrong results.

```text
100 * -1 % -91 == 82
```

![image](./neo-go-3598.png)

## Expected behavior

C# (neo) results:

```text
100 * -1 % -91 == -9
```

## Extra info

Relevant for Commit (neo-go): `c960a7eb4799ffa1cf8a5428a91d9fb2c86ac69e`
Binary file added bugs/neo-go-3598.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
29 changes: 29 additions & 0 deletions bugs/neo-go-3612.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
# MODPOW operation returns wrong results for negative numbers

## Minimal case

```text
DxMTpg==
```

## What is wrong

For negative base MODPOW operation returns wrong results.

```text
(-1 ^ 3) % 3 == 2
```

![image](./neo-go-3612.png)

## Expected behavior

C# (neo) results:

```text
(-1 ^ 3) % 3 == -1
```

## Extra info

Relevant for Commit (neo-go): `a9242535db757faba860e21c194033f30c679f48`
Binary file added bugs/neo-go-3612.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
71 changes: 71 additions & 0 deletions bugs/neo-go-3613.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,71 @@
# PACKMAP operation keeps duplicate entries

## Minimal case

```text
ERERERK+
```

## What is wrong

PACKMAP operations keeps duplicate keys (and entries).

```json
[
{
"type": "Map",
"value": [
{
"key": {
"type": "Integer",
"value": "1"
},
"value": {
"type": "Integer",
"value": "1"
}
},
{
"key": {
"type": "Integer",
"value": "1"
},
"value": {
"type": "Integer",
"value": "1"
}
}
]
}
]
```

![image](./neo-go-3613.png)

## Expected behavior

C# (neo) results:

```json
[
{
"type": "Map",
"value": [
{
"key": {
"type": "Integer",
"value": "1"
},
"value": {
"type": "Integer",
"value": "1"
}
}
]
}
]
```

## Extra info

Relevant for Commit (neo-go): `a9242535db757faba860e21c194033f30c679f48`
Binary file added bugs/neo-go-3613.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.

0 comments on commit d89b6ce

Please sign in to comment.