Fixing Clippy warnings, some refactors and optimizations #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @FastestMolasses , thanks for your PR, especially for the fix of the demo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm using clippy and when importing this project into mine, it generates a ton of warnings and suggestions for fixes in code. I went ahead and fixed all these warnings for my project and if this is something you would like to include as well, then feel free to include! My changes passes all tests too.
EDIT: Looks like I mistakenly included some code to upgrade to Bevy 0.14. This is an issue because it requires that glam goes back to version 0.27 to match the Bevy version in 0.14. Let me know if you want to include this PR in the first place and we can discuss what to do with the extra commits.