[Feature] Clickers (Bubba, Poppy and Orion)#304
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
What do you think will be the use for most of these functions? (anything that isn't the global bonus)
Like happiness rank is such a point in time thing, will we really display that? 🤔
I don't personally have an idea of how to use any of that, so wondering if you had anything cool in mind 😄
There was a problem hiding this comment.
Nah sadly not, as you said it's pretty hard to use those in IE, but maybe we can still use the happiness multi for display purposes to inform how much meat would be gained at each hapiness stage 🤔
There was a problem hiding this comment.
To be honest, I rather we keep this class super simple and just focus on the global bonuses for now and remove all the other noise. This should help simplify your effort for the other clickers as well since they can do the same thing.
If we ever want to display more (for some reason which I can't think of right now haha), we can do that later.
What do you think?
There was a problem hiding this comment.
Well, others are way more simple than Bubba, the generation rate will always be easy to calculate using only the upgrades, and will never be subject to change unless the user upgrade something, there's nothing like happiness '-'
I think we can just left Bubba as it is, if we just need to get the global bonuses there's already what is needed, and if we need to dig deeper for some reason we can change what is needed I guess '-'
There was a problem hiding this comment.
unless the user upgrade something
Don't you upgrade things like 3000 times a minute in clickers? That's literally the point of it 😆
What's the value of a point in time feather / feathers per second / fishing / shiny fish / meat etc.
Look at this page https://idleontoolbox.com/account/clickers/owl and tell me what value you get out of it
There was a problem hiding this comment.
Only thing I could think of is to know if the user could buy an important upgrade since he last triggered a cloudsave and make an alert to go check it
Of course there's no really important uses '-'
There was a problem hiding this comment.
It's just that I've done the translation to IE, so I don't want to straight up delete it x)
I modified the getMeatSliceRate() so now we can force it to calculate "worse case rate" by forcing to calculate like there was no happiness
But if you really wish for it we can just delete everythgin not global bonus related
Now each files is in the world folder it belongs to, to make it easier to find a specific file There have been a few small modifications like a space character added/removed in some places due to AI helping me out to correct all using I've reviewed manually each file (I guess there was too many and AI couldn't handle it all x) ) so I can guarantee nothing broke from this
Zoma-Ancestral
changed the title
Zoma-Ancestral
changed the title
Forgot to fix this page, but now Vercel should be happy
…after) Just in case we modify some things like Sigils to display an alert when sigil is ready to level up
The value is still a bit off, it's missing Palette bonus, the biggest gap is because summoning winner bonuses are missing some multi Bonus from bubble might also be off if the bubble is prismatic
Added a Math.floor() to avoid having gap between IE and game because of this
Added the new W7 totem so it's displayed and the max reached wave is also computed into the total max waves for Tome and other places Added the two new bonuses to MSA, and updated calculations of all bonuses Updated the Totem getSoulRewards() function to now be accurate with in-game, and added to the UI two new fields for the user to input the values which could change based on character and equipment (the other bonuses are retrieved from relevant domain class)
Cost is still a bit off because of gaming palette bonus missing, but everything else should be fine I slightly changed how gaming gives atom the super bit bonuses to avoid having two foreach in a row
|
PR should be good for now, everything I planned for it (and even a bit more) is done |
Sludging
left a comment
Sludging
left a comment
There was a problem hiding this comment.
I modified some stuff and added tests, good work on this!
A lot of difficult stuff in this
| { worship.dementiaSetAlwaysActive ? | ||
| <Text margin={{top:'xsmall'}} size='small'>You always get the set effect because of armor-set smithy</Text> | ||
| : | ||
| <Text margin={{top:'xsmall'}} size='small'>To avoid character checking for a global page, use this checkbox to consider it equipped or not</Text> |
There was a problem hiding this comment.
Can you improve the wording on this one? I don't think it's very clear to someone who's not familiar with "character specific" bonuses like this
data/domain/player.tsx
Outdated
| } | ||
| }); | ||
|
|
||
| // 5. Distribution Linéaire à l'intérieur du bloc additif |
2 participants
This PR aims to implement the 3 clickers currently in the game : Orion, Poppy and Bubba
TODO :
Systems updated with Bubba global bonus (Poppy and Orion don't have any IE can make a use of) :