Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Noticed the index have changed since last time while working on summoning
Is still a bit off on some bonuses, I'll investigate why
Now use the index instead of the bonus ID so it's easier to understand which bonus to use, as the ID starts from 1 but most of the game logic still calls winner bonuses starting from 0 (so using the index)
Now retrieve the number of stone boss victories Also merged the two func which updates upgrades as there's no reason to keep it split
Like this we can get the same level of accuracy in IE as what we can see in-game
Now display the number of stone boss kill for the color
Verified that some values are now accurate, and also computed new ones
Collaborator
Author
|
PR should be ready to merge Winner bonuses are accurate, and Upgrade bonuses are a bit off because the Arcane Cultist talents are off (because the bonus talents levels are a bit off, missing a few levels), this should be adressed in the same future PR as Super Talents |
Formatted the values of cost reduction upgrades so it's displayed in same way as in-game (an under 100 percentage of reduction)
Sludging
approved these changes
Feb 22, 2026
Owner
Sludging
left a comment
Sludging
left a comment
There was a problem hiding this comment.
I didn't add all the tests I wanted yet but merging this so we can work on world 7 part 2 without this being open.
Good work on this overall!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to update Summoning