-
Notifications
You must be signed in to change notification settings - Fork 453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Matter Sensor: return nil if no unit conversion is possible #1582
Open
ctowns
wants to merge
2
commits into
main
Choose a base branch
from
matter-sensor-nil-unit-conversion
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Invitation URL: |
ctowns
force-pushed
the
matter-sensor-nil-unit-conversion
branch
from
August 15, 2024 19:12
f56e846
to
f90ea39
Compare
Minimum allowed coverage is Generated by 🐒 cobertura-action against 602bced |
tpmanley
reviewed
Aug 15, 2024
drivers/SmartThings/matter-sensor/src/air-quality-sensor/init.lua
Outdated
Show resolved
Hide resolved
ctowns
force-pushed
the
matter-sensor-nil-unit-conversion
branch
from
August 15, 2024 19:50
f90ea39
to
0c5e8c0
Compare
tpmanley
reviewed
Aug 15, 2024
drivers/SmartThings/matter-sensor/src/air-quality-sensor/init.lua
Outdated
Show resolved
Hide resolved
tpmanley
reviewed
Aug 15, 2024
nickolas-deboom
approved these changes
Sep 5, 2024
LGTM! |
tpmanley
approved these changes
Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check all that apply
Type of Change
Checklist
Description of Change
Summary of Completed Tests