-
Notifications
You must be signed in to change notification settings - Fork 453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CHAD-14119: Add support for Extractor Hood On/Off light #1680
base: main
Are you sure you want to change the base?
CHAD-14119: Add support for Extractor Hood On/Off light #1680
Conversation
Duplicate profile check: Passed - no duplicate profiles detected. |
Invitation URL: |
Test Results 64 files 400 suites 0s ⏱️ Results for commit c0684fb. ♻️ This comment has been updated with latest results. |
Minimum allowed coverage is Generated by 🐒 cobertura-action against c0684fb |
version: 1 | ||
categories: | ||
- name: KitchenHood | ||
- id: switch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think light
would be a more appropriate name for the component
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated as suggested in latest commit.
deviceTypes: | ||
- id: 0x007A | ||
- id: 0x0100 | ||
deviceProfileName: extractor-hood-light-binary |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the meaning of binary
in this context?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The OnOff light device type in matter-switch fingerprints to the light-binary
profile, so I borrowed that same name here. Would just light
be better?
Type of Change
Checklist
Description of Change
CHAD-14119
Extractor Hoods can include the On/Off light in its device composition. This change adds a new fingerprint and new profiles to support this feature.
Summary of Completed Tests
See new unit test in
test_matter_extractor_hood.lua
.