Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fp2: add get_credential failure handling #1719

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

hdlee27
Copy link
Contributor

@hdlee27 hdlee27 commented Oct 24, 2024

Check all that apply

Type of Change

  • WWST Certification Request
    • If this is your first time contributing code:
      • I have reviewed the README.md file
      • I have reviewed the CODE_OF_CONDUCT.md file
      • I have signed the CLA
    • I plan on entering a WWST Certification Request or have entered a request through the WWST Certification console at developer.smartthings.com
  • Bug fix
  • New feature
  • Refactor

Checklist

  • I have performed a self-review of my code
  • I have commented my code in hard-to-understand areas
  • I have verified my changes by testing with a device or have communicated a plan for testing
  • I am adding new behavior, such as adding a sub-driver, and have added and run new unit tests to cover the new behavior

Description of Change

When 403 error occurs after get_credential during device registration, the driver is waiting for socket timeout to occur while calling fill_body().

In the event of a 403 error, there is no need to fill the body, so in this case, the fill_body() is not called and treated as an error so that a quick return can be made.

This will help users with multiple devices quickly register their devices.

In addition, the log was changed more clearly when get_creditial failed.

Summary of Completed Tests

complete fp2 registration test on V3

Signed-off-by: hdlee27 <54927573+hdlee27@users.noreply.github.com>
Copy link

Test Results

   64 files    400 suites   0s ⏱️
1 989 tests 1 989 ✅ 0 💤 0 ❌
3 429 runs  3 429 ✅ 0 💤 0 ❌

Results for commit a110475.

Copy link

Minimum allowed coverage is 90%

Generated by 🐒 cobertura-action against a110475

Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant