Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/active interface change #768

Merged
merged 8 commits into from
Jul 26, 2023
Merged

Conversation

nicktaras
Copy link
Collaborator

Adjusted Active and Passive modes selected tokens interface towards version 3.0.0.

@github-actions
Copy link

github-actions bot commented Jul 24, 2023

Coverage report

St.
Category Percentage Covered / Total
🔴 Statements
38.29% (+0.46% 🔼)
1345/3513
🔴 Branches
24.73% (+0.12% 🔼)
372/1504
🔴 Functions
38.38% (+0.03% 🔼)
185/482
🔴 Lines
38.55% (+0.52% 🔼)
1140/2957
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🔴
... / wallet-info.ts
38.64% (-1.79% 🔻)
0% 0%
45.95% (-1.55% 🔻)
🟡
... / nftProvider.ts
79.01% (+21.03% 🔼)
55.56% (+3.66% 🔼)
77.78% (-2.22% 🔻)
79.31% (+25.46% 🔼)
🔴
... / UN.ts
24.49% (-0.51% 🔻)
0% 20%
28.21% (-0.37% 🔻)

Test suite run success

86 tests passing in 9 suites.

Report generated by 🧪jest coverage report action from 8cec2e6

micwallace
micwallace previously approved these changes Jul 25, 2023
@micwallace micwallace self-requested a review July 25, 2023 02:51
src/client/index.ts Outdated Show resolved Hide resolved
@micwallace micwallace dismissed their stale review July 25, 2023 04:03

Changes required

@micwallace micwallace self-requested a review July 25, 2023 04:04
@sonarcloud
Copy link

sonarcloud bot commented Jul 26, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@nicktaras nicktaras merged commit 16c5523 into staging Jul 26, 2023
5 checks passed
@nicktaras nicktaras deleted the feature/active-interface-change branch September 18, 2023 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants