Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix long names thumbnail #545

Closed
wants to merge 3 commits into from

Conversation

LePetitTim
Copy link

  • Do not use hash for SEO
  • Truncate end of the file after generate thumbnail
  • Add tests with long names

#388

- Do not use hash for SEO
- Truncate end of the file after generate thumbnail
- Add tests with long names
@jrief
Copy link
Collaborator

jrief commented Oct 4, 2020

Thanks for your pull request. After looking at your code, I would like to add my annotations:

  • High resolution will go away, so there is no need to add tests for it explicitly.
  • Why didn't you create an alternative namer function, say truncator and add it to easythubnails.namers. Then one can use either the new namer to create truncated names with a hash, if the source name is too long, or the existing default namer. This could help to prevent compatibility issues. What's your opinion?

@jrief
Copy link
Collaborator

jrief commented Nov 23, 2020

Closing for inactivity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants