Skip to content

Conversation

@jbredwards
Copy link

Add an optional Fluidlogged API dependency, instead of re-implementing fluidlogging logic from scratch.

Pros:

  • Common logic for fluidlogging (automatic compatibility with other mods that use Fluidlogged API).
  • Much more robust (Fluidlogged API has been in development for years).

Cons:

  • Players have to install another mod if they want to fluidlog a copper grate, if they don't already have Fluidlogged API.

@SmileycorpMC
Copy link
Owner

This is a prototype system for functionality that will required in the base mod when sculk sensors are added.

The end goal is to add cross compatibility between it and fluidlogged, but it needs to be required in the base mod.

@jbredwards
Copy link
Author

If that's the case, perhaps you should consider adding Fluidlogged API as a required dependency? Doing so would definitely simplify things down the line. After all, the whole point of Fluidlogged API is to serve as a library for other mods to use 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants