Fix memory leak unsetting master

Snapchat · Apr 11, 2019 · e951386 · e951386
1 parent 715de15
commit e951386
Showing 1 changed file with 8 additions and 0 deletions.
diff --git a/src/replication.cpp b/src/replication.cpp
@@ -2263,6 +2263,13 @@ struct redisMaster *replicationAddMaster(char *ip, int port) {
     return mi;
 }
 
+void freeMasterInfo(redisMaster *mi)
+{
+    zfree(mi->masterauth);
+    zfree(mi->masteruser);
+    zfree(mi);
+}
+
 /* Cancel replication, setting the instance as a master itself. */
 void replicationUnsetMaster(redisMaster *mi) {
     serverAssert(mi->masterhost != NULL);
@@ -2305,6 +2312,7 @@ void replicationUnsetMaster(redisMaster *mi) {
     listNode *ln = listSearchKey(server.masters, mi);
     serverAssert(ln != nullptr);
     listDelNode(server.masters, ln);
+    freeMasterInfo(mi);
 }
 
 /* This function is called when the slave lose the connection with the