Fix integer overflow issue in the temp rdb file naming #702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to fix a bug related to integer overflow issue in the temp rdb file naming, especially in the current time (in milliseconds) portion in the file name.
It is possible that the temp rdb file name (i.e.,
temp-<timestamp>.<pid>.rdb) might have incorrect (possibly negative) timestamp value. Therefore, it is preferred to change the data type tolong longto be at least 64 bits in length.An example current time in milliseconds = 1690471817044.
@JohnSully / @msotheeswaran-sc could you please review and merge? thanks.
@paulmchen @hengku @yzhao244