Use official C++ 20 coroutine feature test macro #176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think that you can remove comment "// __cpp_coroutines is outdated, __cpp_impl_coroutine is the standard feature test macro", no? |
__cpp_coroutines is no longer defined by clang starting at clang 17
jb-gcx
force-pushed
the
gcx/coroutine-feature-test
branch
from
99298a2
to
36c027e
Compare
|
True, done 👍 |
li-feng-sc
approved these changes
Jul 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The djinni::Future coroutine support stops working at clang 17, see the reason here: https://stackoverflow.com/a/78027460/1480324
In this PR I use the updated the feature test macro as well as the outdated one.