-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Swift support #178
Open
li-feng-sc
wants to merge
86
commits into
experimental-record
Choose a base branch
from
lf/swift-support
base: experimental-record
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add Swift support #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use std::expected for outcome when available
Fix compiler warnings in Future implementation
Make DJFuture results nonnull in objective C
__cpp_coroutines is no longer defined by clang starting at clang 17
o.o |
When non-nullable pointers are set, externally defined interface types were not being treated the same as file-local interface types, causing missing import headers and incorrect pointer types to be used in C++ generated code.
Add SharedFuture
Fixing a minor type.
Small error in README.md
Finish futures when their promise is broken
What Swift version is required? |
5.9+ i think as it uses the c++ interop |
I check here, you are correct, thanks. |
clang++: error: unknown argument: '-fcoroutines-ts' is thrown with Xcode 16
Remove -fcoroutines-ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds first class Swift support without going through ObjC bridge.
New command line switches
The Swift code output directory.
The Swift module name. This is used to generate “import” statements that references this module.
The C++ bridge code output directory.
The prefix for #includes of the main header files from Swift C++ files
Swift C++ interop support library relative path
The naming convention of generated C++ bridge classes. For example, “SwiftFooBar”.
The naming convention of generated C++ files. For example, “SwiftFooBar”.
The generated code
The generated code in the output directories has 3 parts:
These are “*.swift” files without “+Private” suffix under the output directory specified by “--swift-out”. They contain Swift definitions for Djinni enums, records, and interfaces.
These are “*+Private.swift” files in the same directory as Swift API module files specified by “--swift-out”. They contain:
These are “.h” and “.cpp” files under the output directory specified by “--swiftxx-out”. They contain:
Notable improvements over ObjC bridge