Pre-release stream fixes #14

s-vitaliy · 2024-07-10T09:48:13Z

Part of #5

Scope

Implemented:

Fixed incorrect appVersion in Chart.yaml
Use the more descriptive plural blob-storage-streams instead of blob-storages
Make the sourceCredentialRef and targetCredentialRef optional
Use the application full name in the stream class name.
Implement keyed service injections for the source and the target Amazon SDK client injection.
Fixed incorrect path resolution in the stream.

Checklist

GitHub issue exists for this change.
Unit tests added and they pass.
Line Coverage is at least 80%.
Review requested on latest commit.

github-actions · 2024-07-10T09:59:57Z

Coverage after merging test-with-new-snd-sdk-version into main will be

31.18%

Coverage Report

File	Stmts	Branches	Funcs	Lines	Uncovered Lines
src
Program.cs	0%	100%	0%	0%	14, 18–37, 39–42, 45–47, 49
src/Exceptions
ConfigurationException.cs	0%	100%	0%	0%	10–11, 13
SinkException.cs	100%	100%	100%	100%
src/Extensions
ServiceCollectionExtensions.cs	0%	0%	0%	0%	100–104, 106–111, 114–123, 35–39, 39, 39–50, 53–57, 57, 57–68, 71–75, 75, 75–86, 89–93, 93, 93–99
StreamContextExtensions.cs	100%	100%	100%	100%
src/GraphBuilder
BlobStorageGraphBuilder.cs	86.54%	50%	100%	88.64%	39–41, 43–45, 67

github-actions · 2024-07-10T10:30:13Z

Coverage after merging test-with-new-snd-sdk-version into main will be

31.18%

Coverage Report

File	Stmts	Branches	Funcs	Lines	Uncovered Lines
src
Program.cs	0%	100%	0%	0%	14, 18–37, 39–42, 45–47, 49
src/Exceptions
ConfigurationException.cs	0%	100%	0%	0%	10–11, 13
SinkException.cs	100%	100%	100%	100%
src/Extensions
ServiceCollectionExtensions.cs	0%	0%	0%	0%	100–104, 106–111, 114–123, 35–39, 39, 39–50, 53–57, 57, 57–68, 71–75, 75, 75–86, 89–93, 93, 93–99
StreamContextExtensions.cs	100%	100%	100%	100%
src/GraphBuilder
BlobStorageGraphBuilder.cs	86.54%	50%	100%	88.64%	39–41, 43–45, 67

github-actions · 2024-07-10T10:58:19Z

Coverage after merging test-with-new-snd-sdk-version into main will be

31.18%

Coverage Report

File	Stmts	Branches	Funcs	Lines	Uncovered Lines
src
Program.cs	0%	100%	0%	0%	14, 18–37, 39–42, 45–47, 49
src/Exceptions
ConfigurationException.cs	0%	100%	0%	0%	10–11, 13
SinkException.cs	100%	100%	100%	100%
src/Extensions
ServiceCollectionExtensions.cs	0%	0%	0%	0%	100–104, 106–111, 114–123, 35–39, 39, 39–50, 53–57, 57, 57–68, 71–75, 75, 75–86, 89–93, 93, 93–99
StreamContextExtensions.cs	100%	100%	100%	100%
src/GraphBuilder
BlobStorageGraphBuilder.cs	86.54%	50%	100%	88.64%	39–41, 43–45, 67

github-actions · 2024-07-10T11:17:30Z

Coverage after merging test-with-new-snd-sdk-version into main will be

31.18%

Coverage Report

File	Stmts	Branches	Funcs	Lines	Uncovered Lines
src
Program.cs	0%	100%	0%	0%	14, 18–37, 39–42, 45–47, 49
src/Exceptions
ConfigurationException.cs	0%	100%	0%	0%	10–11, 13
SinkException.cs	100%	100%	100%	100%
src/Extensions
ServiceCollectionExtensions.cs	0%	0%	0%	0%	100–104, 106–111, 114–123, 35–39, 39, 39–50, 53–57, 57, 57–68, 71–75, 75, 75–86, 89–93, 93, 93–99
StreamContextExtensions.cs	100%	100%	100%	100%
src/GraphBuilder
BlobStorageGraphBuilder.cs	86.54%	50%	100%	88.64%	39–41, 43–45, 67

…nto test-with-new-snd-sdk-version

github-actions · 2024-07-10T11:48:27Z

Coverage after merging test-with-new-snd-sdk-version into main will be

31.18%

Coverage Report

File	Stmts	Branches	Funcs	Lines	Uncovered Lines
src
Program.cs	0%	100%	0%	0%	14, 18–37, 39–42, 45–47, 49
src/Exceptions
ConfigurationException.cs	0%	100%	0%	0%	10–11, 13
SinkException.cs	100%	100%	100%	100%
src/Extensions
ServiceCollectionExtensions.cs	0%	0%	0%	0%	100–104, 106–111, 114–123, 35–39, 39, 39–50, 53–57, 57, 57–68, 71–75, 75, 75–86, 89–93, 93, 93–99
StreamContextExtensions.cs	100%	100%	100%	100%
src/GraphBuilder
BlobStorageGraphBuilder.cs	86.54%	50%	100%	88.64%	39–41, 43–45, 67

github-actions · 2024-07-10T11:49:01Z

Coverage after merging test-with-new-snd-sdk-version into main will be

31.18%

Coverage Report

File	Stmts	Branches	Funcs	Lines	Uncovered Lines
src
Program.cs	0%	100%	0%	0%	14, 18–37, 39–42, 45–47, 49
src/Exceptions
ConfigurationException.cs	0%	100%	0%	0%	10–11, 13
SinkException.cs	100%	100%	100%	100%
src/Extensions
ServiceCollectionExtensions.cs	0%	0%	0%	0%	100–104, 106–111, 114–123, 35–39, 39, 39–50, 53–57, 57, 57–68, 71–75, 75, 75–86, 89–93, 93, 93–99
StreamContextExtensions.cs	100%	100%	100%	100%
src/GraphBuilder
BlobStorageGraphBuilder.cs	86.54%	50%	100%	88.64%	39–41, 43–45, 67

github-actions · 2024-07-10T11:58:46Z

Coverage after merging test-with-new-snd-sdk-version into main will be

31.18%

Coverage Report

File	Stmts	Branches	Funcs	Lines	Uncovered Lines
src
Program.cs	0%	100%	0%	0%	14, 18–37, 39–42, 45–47, 49
src/Exceptions
ConfigurationException.cs	0%	100%	0%	0%	10–11, 13
SinkException.cs	100%	100%	100%	100%
src/Extensions
ServiceCollectionExtensions.cs	0%	0%	0%	0%	100–104, 106–111, 114–123, 35–39, 39, 39–50, 53–57, 57, 57–68, 71–75, 75, 75–86, 89–93, 93, 93–99
StreamContextExtensions.cs	100%	100%	100%	100%
src/GraphBuilder
BlobStorageGraphBuilder.cs	86.54%	50%	100%	88.64%	39–41, 43–45, 67

github-actions · 2024-07-10T12:35:29Z

Coverage after merging test-with-new-snd-sdk-version into main will be

31.18%

Coverage Report

File	Stmts	Branches	Funcs	Lines	Uncovered Lines
src
Program.cs	0%	100%	0%	0%	14, 18–37, 39–42, 45–47, 49
src/Exceptions
ConfigurationException.cs	0%	100%	0%	0%	10–11, 13
SinkException.cs	100%	100%	100%	100%
src/Extensions
ServiceCollectionExtensions.cs	0%	0%	0%	0%	100–104, 106–111, 114–123, 35–39, 39, 39–50, 53–57, 57, 57–68, 71–75, 75, 75–86, 89–93, 93, 93–99
StreamContextExtensions.cs	100%	100%	100%	100%
src/GraphBuilder
BlobStorageGraphBuilder.cs	86.54%	50%	100%	88.64%	39–41, 43–45, 67

github-actions · 2024-07-11T13:12:35Z

Coverage after merging test-with-new-snd-sdk-version into main will be

29.61%

Coverage Report

File	Stmts	Branches	Funcs	Lines	Uncovered Lines
src
Program.cs	0%	100%	0%	0%	14, 18–37, 39–42, 45–47, 49
src/Exceptions
ConfigurationException.cs	0%	100%	0%	0%	10–11, 13
SinkException.cs	100%	100%	100%	100%
src/Extensions
ServiceCollectionExtensions.cs	0%	0%	0%	0%	100–104, 106, 106, 106–114, 118–119, 119, 119, 119, 119–122, 125–134, 137, 137, 137, 137, 137, 35–39, 39, 39–50, 53–57, 57, 57–68, 71–75, 75, 75–86, 89–93, 93, 93–99
StreamContextExtensions.cs	100%	100%	100%	100%
src/GraphBuilder
BlobStorageGraphBuilder.cs	86.54%	50%	100%	88.64%	39–41, 43–45, 67

github-actions · 2024-07-11T13:40:55Z

Coverage after merging test-with-new-snd-sdk-version into main will be

29.61%

Coverage Report

File	Stmts	Branches	Funcs	Lines	Uncovered Lines
src
Program.cs	0%	100%	0%	0%	14, 18–37, 39–42, 45–47, 49
src/Exceptions
ConfigurationException.cs	0%	100%	0%	0%	10–11, 13
SinkException.cs	100%	100%	100%	100%
src/Extensions
ServiceCollectionExtensions.cs	0%	0%	0%	0%	100–104, 106, 106, 106–114, 118–119, 119, 119, 119, 119–122, 125–134, 137, 137, 137, 137, 137, 35–39, 39, 39–50, 53–57, 57, 57–68, 71–75, 75, 75–86, 89–93, 93, 93–99
StreamContextExtensions.cs	100%	100%	100%	100%
src/GraphBuilder
BlobStorageGraphBuilder.cs	86.54%	50%	100%	88.64%	39–41, 43–45, 67

github-actions · 2024-07-11T14:05:43Z

Coverage after merging test-with-new-snd-sdk-version into main will be

29.61%

Coverage Report

File	Stmts	Branches	Funcs	Lines	Uncovered Lines
src
Program.cs	0%	100%	0%	0%	14, 18–37, 39–42, 45–47, 49
src/Exceptions
ConfigurationException.cs	0%	100%	0%	0%	10–11, 13
SinkException.cs	100%	100%	100%	100%
src/Extensions
ServiceCollectionExtensions.cs	0%	0%	0%	0%	100–104, 106, 106, 106–114, 118–119, 119, 119, 119, 119–122, 125–134, 137, 137, 137, 137, 137, 35–39, 39, 39–50, 53–57, 57, 57–68, 71–75, 75, 75–86, 89–93, 93, 93–99
StreamContextExtensions.cs	100%	100%	100%	100%
src/GraphBuilder
BlobStorageGraphBuilder.cs	86.54%	50%	100%	88.64%	39–41, 43–45, 67

github-actions · 2024-07-11T14:16:59Z

Coverage after merging test-with-new-snd-sdk-version into main will be

29.94%

Coverage Report

File	Stmts	Branches	Funcs	Lines	Uncovered Lines
src
Program.cs	0%	100%	0%	0%	14, 18–39, 41–44, 47–49, 51
src/Exceptions
ConfigurationException.cs	0%	100%	0%	0%	10–11, 13
SinkException.cs	100%	100%	100%	100%
src/Extensions
ServiceCollectionExtensions.cs	0%	0%	0%	0%	100, 102, 102, 102–110, 114–115, 115, 115, 115, 115–118, 121–130, 133, 133, 133, 133, 133, 35–39, 39, 39–49, 52–56, 56, 56–66, 69–73, 73, 73–83, 86–90, 90, 90–99
StreamContextExtensions.cs	100%	100%	100%	100%
src/GraphBuilder
BlobStorageGraphBuilder.cs	86.54%	50%	100%	88.64%	39–41, 43–45, 67

github-actions · 2024-07-12T08:29:18Z

Coverage after merging test-with-new-snd-sdk-version into main will be

29.94%

Coverage Report

File	Stmts	Branches	Funcs	Lines	Uncovered Lines
src
Program.cs	0%	100%	0%	0%	14, 18–39, 41–44, 47–49, 51
src/Exceptions
ConfigurationException.cs	0%	100%	0%	0%	10–11, 13
SinkException.cs	100%	100%	100%	100%
src/Extensions
ServiceCollectionExtensions.cs	0%	0%	0%	0%	100, 102, 102, 102–110, 114–115, 115, 115, 115, 115–118, 121–130, 133, 133, 133, 133, 133, 35–39, 39, 39–49, 52–56, 56, 56–66, 69–73, 73, 73–83, 86–90, 90, 90–99
StreamContextExtensions.cs	100%	100%	100%	100%
src/GraphBuilder
BlobStorageGraphBuilder.cs	86.54%	50%	100%	88.64%	39–41, 43–45, 67

github-actions · 2024-07-12T08:35:04Z

Coverage after merging test-with-new-snd-sdk-version into main will be

57.14%

Coverage Report

File	Stmts	Branches	Funcs	Lines	Uncovered Lines
src
Program.cs	0%	100%	0%	0%	14, 18–39, 41–44, 47–49, 51
src/Exceptions
ConfigurationException.cs	0%	100%	0%	0%	10–11, 13
SinkException.cs	100%	100%	100%	100%
src/Extensions
StreamContextExtensions.cs	100%	100%	100%	100%
src/GraphBuilder
BlobStorageGraphBuilder.cs	86.27%	50%	100%	88.37%	39–41, 43–45, 66

github-actions · 2024-07-12T08:46:18Z

Coverage after merging test-with-new-snd-sdk-version into main will be

58.51%

Coverage Report

File	Stmts	Branches	Funcs	Lines	Uncovered Lines
src
Program.cs	0%	100%	0%	0%	14, 18–39, 41–44, 47–49, 51
src/Exceptions
ConfigurationException.cs	0%	100%	0%	0%	10–11, 13
SinkException.cs	100%	100%	100%	100%
src/Extensions
StreamContextExtensions.cs	100%	100%	100%	100%
src/GraphBuilder
BlobStorageGraphBuilder.cs	87.04%	50%	100%	89.13%	43–45, 47–49, 71

github-actions · 2024-07-12T09:43:05Z

Coverage after merging test-with-new-snd-sdk-version into main will be

58.95%

Coverage Report

File	Stmts	Branches	Funcs	Lines	Uncovered Lines
src
Program.cs	0%	100%	0%	0%	14, 18–39, 41–44, 47–49, 51
src/Exceptions
ConfigurationException.cs	0%	100%	0%	0%	10–11, 13
SinkException.cs	100%	100%	100%	100%
src/Extensions
StreamContextExtensions.cs	92.86%	50%	100%	100%
src/GraphBuilder
BlobStorageGraphBuilder.cs	87.27%	50%	100%	89.36%	43–45, 47–49, 72

github-actions · 2024-07-12T12:19:42Z

Coverage after merging test-with-new-snd-sdk-version into main will be

59.63%

Coverage Report

File	Stmts	Branches	Funcs	Lines	Uncovered Lines
src
Program.cs	0%	100%	0%	0%	14, 18–39, 41–44, 47–49, 51
src/Exceptions
ConfigurationException.cs	0%	100%	0%	0%	10–11, 13
ProcessingException.cs	100%	100%	100%	100%
SinkException.cs	0%	100%	0%	0%	10–12
src/Extensions
StreamContextExtensions.cs	100%	100%	100%	100%
src/GraphBuilder
BlobStorageGraphBuilder.cs	86.84%	62.50%	100%	88.89%	100–101, 43–45, 48–50, 73, 99

src/Extensions/StreamContextExtensions.cs

src/GraphBuilder/BlobStorageGraphBuilder.cs

Co-authored-by: George Zubrienko <zubrienkog@gmail.com>

github-actions · 2024-07-12T12:54:36Z

Coverage after merging test-with-new-snd-sdk-version into main will be

61.54%

Coverage Report

File	Stmts	Branches	Funcs	Lines	Uncovered Lines
src
Program.cs	0%	100%	0%	0%	14, 18–39, 41–44, 47–49, 51
src/Exceptions
ConfigurationException.cs	0%	100%	0%	0%	10–11, 13
ProcessingException.cs	100%	100%	100%	100%
SinkException.cs	0%	100%	0%	0%	10–12
src/Extensions
StreamContextExtensions.cs	100%	100%	100%	100%
src/GraphBuilder
BlobStorageGraphBuilder.cs	86.21%	60%	100%	88.73%	101–103, 109, 111, 44–46, 49–51, 75

s-vitaliy added 2 commits July 10, 2024 11:46

Bump the SND.SDK version

742ac75

Fix unit tests

81e9636

Merge branch 'main' into test-with-new-snd-sdk-version

fd346a1

Merge branch 'main' into test-with-new-snd-sdk-version

1e572ee

Merge branch 'main' into test-with-new-snd-sdk-version

8c19594

s-vitaliy added 3 commits July 10, 2024 13:45

Fix CRD

854037d

Merge remote-tracking branch 'origin/test-with-new-snd-sdk-version' i…

6fdc9c9

…nto test-with-new-snd-sdk-version

Fix blob storage service

006acea

Fix plural name

8c0906b

Also fix streamclass name

db4c1fc

Handle optional credentials

411f860

Fix

93f0a56

Use the correct version of the RunStream method

41f5d0f

s-vitaliy added 2 commits July 11, 2024 16:13

The correct way to inject S3 Client

5208237

Build fix

d9f6b47

Bump Snd.Sdk version

d3f5b65

Bump Arcane.Framework version

a3b454c

Fix unit tests

e32e849

s-vitaliy added 2 commits July 12, 2024 10:40

Add logs, add dependencies

54fed9a

Fix unit tests

8c541e2

s-vitaliy added 2 commits July 12, 2024 11:40

Fix incorrect path representation

1c15a9f

Fix incorrect path representation

8fb68ab

Use new features from SDK

cd5460e

s-vitaliy changed the title ~~Bump the SND.SDK version~~ Pre-release stream fixes Jul 12, 2024

s-vitaliy marked this pull request as ready for review July 12, 2024 12:23

s-vitaliy requested a review from a team as a code owner July 12, 2024 12:23

george-zubrienko approved these changes Jul 12, 2024

View reviewed changes

src/Extensions/StreamContextExtensions.cs Show resolved Hide resolved

src/GraphBuilder/BlobStorageGraphBuilder.cs Outdated Show resolved Hide resolved

src/GraphBuilder/BlobStorageGraphBuilder.cs Show resolved Hide resolved

s-vitaliy and others added 2 commits July 12, 2024 14:41

Update src/GraphBuilder/BlobStorageGraphBuilder.cs

72ba578

Co-authored-by: George Zubrienko <zubrienkog@gmail.com>

Review fix

5066b48

s-vitaliy merged commit 2a5decd into main Jul 12, 2024
2 checks passed

s-vitaliy deleted the test-with-new-snd-sdk-version branch July 12, 2024 12:55

Pre-release stream fixes #14

Pre-release stream fixes #14

Uh oh!

Conversation

s-vitaliy commented Jul 10, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Scope

Checklist

Uh oh!

github-actions bot commented Jul 10, 2024

Uh oh!

github-actions bot commented Jul 10, 2024

Uh oh!

github-actions bot commented Jul 10, 2024

Uh oh!

github-actions bot commented Jul 10, 2024

Uh oh!

github-actions bot commented Jul 10, 2024

Uh oh!

github-actions bot commented Jul 10, 2024

Uh oh!

github-actions bot commented Jul 10, 2024

Uh oh!

github-actions bot commented Jul 10, 2024

Uh oh!

github-actions bot commented Jul 11, 2024

Uh oh!

github-actions bot commented Jul 11, 2024

Uh oh!

github-actions bot commented Jul 11, 2024

Uh oh!

github-actions bot commented Jul 11, 2024

Uh oh!

github-actions bot commented Jul 12, 2024

Uh oh!

github-actions bot commented Jul 12, 2024

Uh oh!

github-actions bot commented Jul 12, 2024

Uh oh!

github-actions bot commented Jul 12, 2024

Uh oh!

github-actions bot commented Jul 12, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Jul 12, 2024

Uh oh!

Uh oh!

Uh oh!

s-vitaliy commented Jul 10, 2024 •

edited

Loading