-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issues 134 133 #135
Merged
Merged
Issues 134 133 #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
micah-prime
commented
Sep 18, 2024
- Add DOI class and table Restructure - DOI table #133
- Add MeasurementType class and table Restructure - measurement type table #134
- Link new tables
- Rework some inheritance and drop some non-needed columns
- Rework API for new tables
- Keep tests passing
… to data classes
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-0.6.x #135 +/- ##
================================================
Coverage ? 77.40%
================================================
Files ? 18
Lines ? 531
Branches ? 0
================================================
Hits ? 411
Misses ? 120
Partials ? 0 ☔ View full report in Codecov by Sentry. |
micah-prime
commented
Sep 18, 2024
micah-prime
commented
Sep 18, 2024
jomey
reviewed
Sep 19, 2024
jomey
reviewed
Sep 19, 2024
jomey
reviewed
Sep 19, 2024
jomey
reviewed
Sep 19, 2024
jomey
reviewed
Sep 19, 2024
jomey
reviewed
Sep 20, 2024
jomey
reviewed
Sep 20, 2024
jomey
reviewed
Sep 20, 2024
jomey
reviewed
Sep 20, 2024
jomey
reviewed
Sep 20, 2024
jomey
reviewed
Sep 20, 2024
jomey
reviewed
Sep 20, 2024
jomey
reviewed
Sep 20, 2024
jomey
approved these changes
Sep 20, 2024
jomey
reviewed
Sep 20, 2024
Merge when ready. Guess there will be many more iterations until we land at the new structure 😄 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.