Merge branch 'release/2.28.4'

SnowdogApps · Apr 6, 2023 · 49dd786 · 49dd786 · vercel · Apr 6, 2023
2 parents dbac9eb + b3a1b79
commit 49dd786
Show file tree

Hide file tree

Showing 5 changed files with 17 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -13,6 +13,10 @@ USE GITHUB ISSUE/PULL REQUEST NUMBERS, NOT INTERNAL ONE
 
 ## [Released]
 
+## [2.28.4] - 2023-04-06
+### Fixed
+- Mage error styles on PDP (#581)
+
 ## [2.28.3] - 2023-03-31
 ### Added
 - Added styles and templates for MageMe_WebForms (old VladimirPopov_WebForms) module (#575)

diff --git a/Magento_ConfigurableProduct/templates/product/view/type/options/configurable.phtml b/Magento_ConfigurableProduct/templates/product/view/type/options/configurable.phtml
@@ -12,6 +12,7 @@ $_attributes = $block->decorateArray($block->getAllowAttributes());
             class="
                 select
                 select--native
+                select--grid
                 field
                 configurable
                 required

diff --git a/Snowdog_Components/components/Molecules/form/select/_select.scss b/Snowdog_Components/components/Molecules/form/select/_select.scss
@@ -86,6 +86,10 @@
         }
     }
 
+    &--grid {
+        display: grid;
+    }
+
     &__button {
         flex-shrink: 0;
         margin: $spacer--medium 0 0;
@@ -137,6 +141,12 @@
 }
 
 // select2 overwrite styles
+.select2-hidden-accessible {
+    & + .mage-error {
+        order: 1;
+    }
+}
+
 .select2 {
     width: 100%;
 }

diff --git a/Snowdog_Components/components/Organisms/quantity-update/_quantity-update.scss b/Snowdog_Components/components/Organisms/quantity-update/_quantity-update.scss
@@ -110,6 +110,7 @@
     }
 
     div.mage-error {
+        position: absolute;
         bottom: $quantity-update__mage-error-bottom;
         width: $quantity-update__mage-error-width;
         order: 4;

diff --git a/Snowdog_Components/components/Templates/product-view/_product-view-variables.scss b/Snowdog_Components/components/Templates/product-view/_product-view-variables.scss
@@ -155,7 +155,7 @@ $product-view__update-requisition-list-width                : 100% !default;
 $product-view__update-requisition-list-button-width         : 100% !default;
 
 // qty
-$product-view__qty-margin                                   : 0 0 $spacer--semi-medium !default;
+$product-view__qty-margin                                   : 0 0 $spacer--large !default;
 
 // stock status
 $product-view__stock-status-margin                          : $spacer--medium 0 0 0 !default;