feat: Use bind variables instead of f-strings for SQL statements #135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-setli
changed the title
sfc-gh-setli
commented
Oct 23, 2025
Collaborator
|
Thank you @sfc-gh-setli! Ran some tests in Cursor and everything seems to be operational. Minor tweak above and we're good to merge. We have a couple other auth items to hopefully knockout today and will cut a new release for PyPI. |
Co-authored-by: Jason Summer <jason.summer@snowflake.com>
sfc-gh-jsummer
approved these changes
Oct 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Increase security posture by replacing f-strings in favor of bind variables when crafting SQL statements (where possible).
I've done manual testing using MCP inspector to invoke the impacted tools, but I also plan to take a stab at adding unit tests.