Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style(ruff): resolve all outstanding default violations #68

Conversation

sfc-gh-twhite
Copy link
Collaborator

This change finally clears all of the basic ruff violations that still existed in the repository. This included things such as:

  • redundant imports, where name conflicts overwrote existing imports
  • importing multiple modules or functions on the same import line
  • base exceptions with catching a specific type (admittedly, going from except: to exception Exception isn't much better but we can handle these separately)
  • removing unused imports

These changes will now make it possible to run the standard ruff check in pre-commit rather than only using the formatted. I also went ahead and updated the versions in the pre-commit file so that we're using the latest.

@sfc-gh-twhite
Copy link
Collaborator Author

@sfc-gh-alherrera - The import separation on the notebooks makes the diff look pretty intimidating; here's a view that makes it much easier to digest.

image

@sfc-gh-twhite
Copy link
Collaborator Author

@sfc-gh-alherrera - we did end up having a conflict after merging in #70, but it was only in the notebook. I took the notebook as you had it and applied the linting fixes so that it still includes the run showing the summarize logs.

Thanks for the approval!

@sfc-gh-twhite sfc-gh-twhite merged commit 8427e62 into Snowflake-Labs:main Dec 2, 2024
2 checks passed
@sfc-gh-twhite sfc-gh-twhite deleted the resolve-base-ruff-check-violations branch December 2, 2024 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants